Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: gpu/command_buffer/service/transform_feedback_manager.h

Issue 2446773002: Always use Desktop GL 4.1 or less BindBufferRange behavior. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/transform_feedback_manager.h
diff --git a/gpu/command_buffer/service/transform_feedback_manager.h b/gpu/command_buffer/service/transform_feedback_manager.h
index f9eb6c39ce3d7ea477ad15121149650a3d9f48ea..e8bd873528a7eb6bda32654d3d62f491e0debbc3 100644
--- a/gpu/command_buffer/service/transform_feedback_manager.h
+++ b/gpu/command_buffer/service/transform_feedback_manager.h
@@ -76,7 +76,9 @@ class GPU_EXPORT TransformFeedback : public IndexedBufferBindingHost {
// This class keeps tracks of the transform feedbacks and their states.
class GPU_EXPORT TransformFeedbackManager {
public:
- // |needs_emulation| is true on Desktop GL 4.1 or lower.
+ // In theory |needs_emulation| needs to be true on Desktop GL 4.1 or lower.
+ // However, we set it to true everywhere, not to trust drivers to handle
+ // out-of-bounds buffer access.
TransformFeedbackManager(GLuint max_transform_feedback_separate_attribs,
bool needs_emulation);
~TransformFeedbackManager();

Powered by Google App Engine
This is Rietveld 408576698