Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2446773002: Always use Desktop GL 4.1 or less BindBufferRange behavior. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder_unittest_buffers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 1914c68d60f10c9c06c2f3734d63862c63340ff0..3c1d9a8aa344a918e94a1924134d6fc60796dccd 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -3103,7 +3103,10 @@ bool GLES2DecoderImpl::Initialize(
}
}
- bool needs_emulation = gl_version_info().IsLowerThanGL(4, 2);
+ // |needs_emulation| is set to true on Desktop GL 4.1 or lower.
+ // For now we set it everywhere to be on the safe side in case drivers
+ // do not handle out-of-bounds visit securely.
Ken Russell (switch to Gerrit) 2016/10/24 21:39:24 How about "visit" -> "accesses"?
Zhenyao Mo 2016/10/24 21:47:30 Done.
+ bool needs_emulation = true;
transform_feedback_manager_.reset(new TransformFeedbackManager(
group_->max_transform_feedback_separate_attribs(), needs_emulation));
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder_unittest_buffers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698