Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2446743002: Remove WebFileChooserParams::initialValue (Closed)
Patch Set: Add browser test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/content_browser_test_utils_internal.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index 29638d43dbcbfb59d35e6b354ee90c6c5c9996e8..398c2967e3a79781579d27dd08d2403e767f583d 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -711,8 +711,6 @@ void ChromeClientImpl::openFileChooser(LocalFrame* frame,
params.directory = fileChooser->settings().allowsDirectoryUpload;
params.acceptTypes = fileChooser->settings().acceptTypes();
params.selectedFiles = fileChooser->settings().selectedFiles;
- if (params.selectedFiles.size() > 0)
- params.initialValue = params.selectedFiles[0];
dcheng 2016/10/25 00:27:35 Is it possible to remove initialValue completely?
jsbell 2016/10/25 16:24:55 Used in PepperFileChooserHost::OnShow apparently,
params.useMediaCapture = fileChooser->settings().useMediaCapture;
params.needLocalPath = fileChooser->settings().allowsDirectoryUpload;
params.requestor = frame->document()->url();
« no previous file with comments | « content/test/content_browser_test_utils_internal.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698