Remove WebFileChooserParams::initialValue

third_party/WebKit/Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 693 matching lines @@
   notifyPopupOpeningObservers();
   WebFrameClient* client = WebLocalFrameImpl::fromFrame(frame)->client();
   if (!client)
     return;
 
   WebFileChooserParams params;
   params.multiSelect = fileChooser->settings().allowsMultipleFiles;
   params.directory = fileChooser->settings().allowsDirectoryUpload;
   params.acceptTypes = fileChooser->settings().acceptTypes();
   params.selectedFiles = fileChooser->settings().selectedFiles;
-  if (params.selectedFiles.size() > 0)
-    params.initialValue = params.selectedFiles[0];

[dcheng, 2016/10/25 00:27:35]

Is it possible to remove initialValue completely?

[jsbell, 2016/10/25 16:24:55]

Used in PepperFileChooserHost::OnShow apparently, which does have a "save as"
path. We could refactor it to use FileChooserParams directly  and split up
runFileChooser() - not sure that would be cleaner.

I've renamed the param (|defaultName|), updated the docs and added a DCHECK.

   params.useMediaCapture = fileChooser->settings().useMediaCapture;
   params.needLocalPath = fileChooser->settings().allowsDirectoryUpload;
   params.requestor = frame->document()->url();
 
   WebFileChooserCompletionImpl* chooserCompletion =
       new WebFileChooserCompletionImpl(std::move(fileChooser));
   if (client->runFileChooser(params, chooserCompletion))
     return;
   // Choosing failed, so do callback with an empty list.
   chooserCompletion->didChooseFile(WebVector<WebString>());
@@ skipping 435 matching lines @@
   if (RuntimeEnabledFeatures::presentationEnabled())
     PresentationController::provideTo(frame, client->presentationClient());
   if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())
     provideAudioOutputDeviceClientTo(frame,
                                      AudioOutputDeviceClientImpl::create());
   if (RuntimeEnabledFeatures::installedAppEnabled())
     InstalledAppController::provideTo(frame, client->installedAppClient());
 }
 
 }  // namespace blink