Issue 24467007: Generate toCSSCalcValue() instead of using manual inline functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24467007: Generate toCSSCalcValue() instead of using manual inline functions (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Generate toCSSCalcValue() instead of using manual inline functions DEFINE_CSS_VALUE_TYPE_CASTS can support better type cast functions. So, this cl replaces existing type cast functions with it. This cl changes isCalculationValue() with isCalcValue() to be sync with CSSCalcValue class as well as generate toCSSFooValue(). BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158363

Patch Set 1 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -17 lines)			Patch
M	Source/core/animation/AnimatableNumber.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSCalculationValue.h	View	1 chunk	+1 line, -11 lines	0 comments	Download
M	Source/core/css/CSSValue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSValue.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/24467007/3001

7 years, 2 months ago (2013-09-26 04:57:30 UTC) #3

Message was sent while issue was closed.

Change committed as 158363

Expand Messages | Collapse Messages