Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 24467007: Generate toCSSCalcValue() instead of using manual inline functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 24467007: Generate toCSSCalcValue() instead of using manual inline functions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/Source/core/css/resolver/StyleBuilderCustom.cpp b/Source/core/css/resolver/StyleBuilderCustom.cpp

index 24cdb1af8fdad275965a8ddc4e53a0daacfde8e2..3f57ca191f16b5fa3b182cb8745fcafca2236548 100644

--- a/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -1207,8 +1207,8 @@ static bool hasVariableReference(CSSValue* value)

return primitiveValue->hasVariableReference();

}

- if (value->isCalculationValue())

- return static_cast<CSSCalcValue*>(value)->hasVariableReference();

+ if (value->isCalcValue())

+ return toCSSCalcValue(value)->hasVariableReference();

if (value->isReflectValue()) {

CSSReflectValue* reflectValue = toCSSReflectValue(value);

« no previous file with comments | « Source/core/css/CSSValue.cpp ('k') | no next file » | no next file with comments »