Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2446643005: Use relative names in GN to make Chromium happy (Closed)

Created:
4 years, 1 month ago by kwiberg-webrtc
Modified:
4 years, 1 month ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use relative names in GN to make Chromium happy A recent CL (https://codereview.chromium.org/2388153004/) introduced absolute names, which caused Chromium builds to fail. TBR=kjellander@webrtc.org BUG=webrtc:5801 Committed: https://crrev.com/a6b8298b48ad0bbacd164c691c8407f8875a69cf Cr-Commit-Position: refs/heads/master@{#14755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2446643005/1
4 years, 1 month ago (2016-10-24 23:29:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 23:31:19 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 23:31:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6b8298b48ad0bbacd164c691c8407f8875a69cf
Cr-Commit-Position: refs/heads/master@{#14755}

Powered by Google App Engine
This is Rietveld 408576698