Fixing a crash when clicking download notification while Chrome is killed

Fixing a crash when clicking download notification while Chrome is killed

When clicking on download notification, Chrome checks if the download file
can be opened by itself.
This calls into a native function.
However, if user kills Chrome, and then clicks the notification, this
generates a Broadcast to Chrome.
When BroadcastReceiver runs, native library is not loaded.
As a result, this generates a crash.
This CL solves the problem by performing the mime type checking when
download completes.
So that we don't need to check it when BroadcastReceiver runs

BUG=658012
Committed: https://crrev.com/ff25b0171fdd6663cc16000071c8d65c3cde1cb0
Cr-Commit-Position: refs/heads/master@{#427204}

[qinmin, 2016-10-24 17:46:54]

qinmin@chromium.org changed reviewers:
+ dfalcantara@chromium.org, fgorski@chromium.org

[qinmin, 2016-10-24 17:46:55]

This is urgent, PTAL

[gone, 2016-10-24 17:53:12]

lgtm

[qinmin, 2016-10-24 18:00:02]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-10-24 18:00:04]

The CQ bit was unchecked by qinmin@chromium.org

[qinmin, 2016-10-24 18:00:11]

The CQ bit was checked by qinmin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 18:00:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Pete Williamson, 2016-10-24 18:50:51]

petewil@chromium.org changed reviewers:
+ petewil@chromium.org

[Pete Williamson, 2016-10-24 18:50:51]

https://codereview.chromium.org/2446643004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
(right):

https://codereview.chromium.org/2446643004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java:137:
long systemDownloadId, boolean canResolve, boolean isSuppostedMimeType) {
nit: isSuppostedMimeType -> isSupportedMimeType (below also)

[qinmin, 2016-10-24 19:25:22]

https://codereview.chromium.org/2446643004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
(right):

https://codereview.chromium.org/2446643004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java:137:
long systemDownloadId, boolean canResolve, boolean isSuppostedMimeType) {
On 2016/10/24 18:50:51, Pete Williamson wrote:
> nit: isSuppostedMimeType -> isSupportedMimeType (below also)

nice catch, fixed

[Pete Williamson, 2016-10-24 20:15:00]

On 2016/10/24 19:25:22, qinmin wrote:
>
https://codereview.chromium.org/2446643004/diff/1/chrome/android/javatests/sr...
> File
>
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
> (right):
> 
>
https://codereview.chromium.org/2446643004/diff/1/chrome/android/javatests/sr...
>
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java:137:
> long systemDownloadId, boolean canResolve, boolean isSuppostedMimeType) {
> On 2016/10/24 18:50:51, Pete Williamson wrote:
> > nit: isSuppostedMimeType -> isSupportedMimeType (below also)
> 
> nice catch, fixed

Much better, thanks!

[qinmin, 2016-10-24 20:53:59]

Patchset #2 (id:20001) has been deleted

[fgorski, 2016-10-24 20:56:32]

offline lgtm

[qinmin, 2016-10-24 20:56:55]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-10-24 20:56:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2446643004/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-10-24 20:57:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:18:00]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[qinmin, 2016-10-24 22:19:42]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:20:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:09:16]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-25 01:11:17]

Description was changed from

==========
Fixing a crash when clicking download notification while Chrome is killed

When clicking on download notification, Chrome checks if the download file
can be opened by itself.
This calls into a native function.
However, if user kills Chrome, and then clicks the notification, this
generates a Broadcast to Chrome.
When BroadcastReceiver runs, native library is not loaded.
As a result, this generates a crash.
This CL solves the problem by performing the mime type checking when
download completes.
So that we don't need to check it when BroadcastReceiver runs

BUG=658012
==========

to

==========
Fixing a crash when clicking download notification while Chrome is killed

When clicking on download notification, Chrome checks if the download file
can be opened by itself.
This calls into a native function.
However, if user kills Chrome, and then clicks the notification, this
generates a Broadcast to Chrome.
When BroadcastReceiver runs, native library is not loaded.
As a result, this generates a crash.
This CL solves the problem by performing the mime type checking when
download completes.
So that we don't need to check it when BroadcastReceiver runs

BUG=658012

Committed: https://crrev.com/ff25b0171fdd6663cc16000071c8d65c3cde1cb0
Cr-Commit-Position: refs/heads/master@{#427204}
==========

[commit-bot: I haz the power, 2016-10-25 01:11:18]

Patchset 2 (id:??) landed as
https://crrev.com/ff25b0171fdd6663cc16000071c8d65c3cde1cb0
Cr-Commit-Position: refs/heads/master@{#427204}