chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java - Issue 2446643004: Fixing a crash when clicking download notification while Chrome is killed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

Issue 2446643004: Fixing a crash when clicking download notification while Chrome is killed (Closed)

Patch Set: nit Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

index a2a85bb2a3549e7a5f7ba92a0f809803303cb225..0cc636550d15b81f04e4de6b198d59e481db1b1d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

@@ -13,9 +13,10 @@ public interface DownloadNotifier {

* @param downloadInfo info about the successful download.

* @param systemDownloadId The system download ID assigned to the download.

* @param canResolve Whether the download can be resolved to any activity.

+ * @param isSupportedMimeType Whether the MIME type can be viewed inside browser.

void notifyDownloadSuccessful(DownloadInfo downloadInfo, long systemDownloadId,

- boolean canResolve);

+ boolean canResolve, boolean isSupportedMimeType);

/**

* Add a download failed notification.