Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2446613003: M55: [pdf] Defer page unloading in JS callback. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
dsinclair
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

M55: [pdf] Defer page unloading in JS callback. One of the callbacks from PDFium JavaScript into the embedder is to get the current page number. In Chromium, this will trigger a call to CalculateMostVisiblePage that method will determine the visible pages and unload any non-visible pages. But, if the originating JS is on a non-visible page we'll delete the page and annotations associated with that page. This will cause issues as we are currently working with those objects when the JavaScript returns. This Cl defers the page unloading triggered by getting the most visible page until the next event is handled by the Chromium embedder. BUG=chromium:653090 Review-Url: https://codereview.chromium.org/2418533002 Cr-Commit-Position: refs/heads/master@{#424781} (cherry picked from commit bf6a6765d44b09c64b8c75d749efb84742a250e7) Committed: https://chromium.googlesource.com/chromium/src/+/ff05b41fda6ab437bd48d7eaaaf538bf7a60479a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Lei Zhang
TBR
4 years, 1 month ago (2016-10-24 20:33:57 UTC) #2
Lei Zhang
4 years, 1 month ago (2016-10-24 20:37:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff05b41fda6ab437bd48d7eaaaf538bf7a60479a.

Powered by Google App Engine
This is Rietveld 408576698