Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2418533002: [pdf] Defer page unloading in JS callback. (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, raymes
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[pdf] Defer page unloading in JS callback. One of the callbacks from PDFium JavaScript into the embedder is to get the current page number. In Chromium, this will trigger a call to CalculateMostVisiblePage that method will determine the visible pages and unload any non-visible pages. But, if the originating JS is on a non-visible page we'll delete the page and annotations associated with that page. This will cause issues as we are currently working with those objects when the JavaScript returns. This Cl defers the page unloading triggered by getting the most visible page until the next event is handled by the Chromium embedder. BUG=chromium:653090 Committed: https://crrev.com/bf6a6765d44b09c64b8c75d749efb84742a250e7 Cr-Commit-Position: refs/heads/master@{#424781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-12 14:52:44 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-12 17:28:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418533002/1
4 years, 2 months ago (2016-10-12 17:29:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 17:37:16 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 17:49:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf6a6765d44b09c64b8c75d749efb84742a250e7
Cr-Commit-Position: refs/heads/master@{#424781}

Powered by Google App Engine
This is Rietveld 408576698