Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2446543003: Differentiate animated image results (Closed)

Created:
4 years, 1 month ago by scroggo_chromium
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Differentiate animated image results Prior to this CL, a kAnimated_Mode CodecSrc (which draws a strip of all frames in an image) has the same name as a non-animated one. This means that Gold compares the two. Someone triaging will see two very different images (a strip versus a single image) and think one of them is wrong. With this change, the two will have different names so they will not be compared with one another. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2446543003 Committed: https://skia.googlesource.com/skia/+/6e8c68e2423e3042e54d6c215f4c43dbf9916839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M dm/DMSrcSink.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
scroggo_chromium
msarett@ FYI, stephana@ thought these should be separate.
4 years, 1 month ago (2016-10-24 19:49:23 UTC) #3
msarett1
lgtm
4 years, 1 month ago (2016-10-24 19:51:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446543003/1
4 years, 1 month ago (2016-10-24 20:21:03 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 1 month ago (2016-10-24 20:21:05 UTC) #8
scroggo
lgtm
4 years, 1 month ago (2016-10-24 20:21:38 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 20:48:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6e8c68e2423e3042e54d6c215f4c43dbf9916839

Powered by Google App Engine
This is Rietveld 408576698