Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2445863002: DM: Draw image frames in a grid (Closed)

Created:
4 years, 1 month ago by scroggo_chromium
Modified:
4 years, 1 month ago
Reviewers:
msarett, scroggo, msarett1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: Draw image frames in a grid Instead of drawing a large vertical strip for CodecSrc::kAnimated_Mode, draw a grid of images. Compute the grid based on the square root of the frame count, so the grid will be roughly square. BUG=skia:5881 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2445863002 Committed: https://skia.googlesource.com/skia/+/90e971a41b1c190732bef34a79a7bdbdabbf5761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M dm/DMSrcSink.cpp View 5 chunks +20 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
scroggo
4 years, 1 month ago (2016-10-24 20:37:17 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2446543003 Patch 1). Please resolve the dependency and ...
4 years, 1 month ago (2016-10-24 20:42:35 UTC) #7
msarett1
I disagree that this is the right way to fix the problem (vs fixing the ...
4 years, 1 month ago (2016-10-24 20:46:59 UTC) #9
scroggo_chromium
On 2016/10/24 20:46:59, msarett1 wrote: > I disagree that this is the right way to ...
4 years, 1 month ago (2016-10-25 12:47:01 UTC) #10
scroggo
lgtm
4 years, 1 month ago (2016-10-25 12:47:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445863002/1
4 years, 1 month ago (2016-10-25 12:47:34 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 13:11:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/90e971a41b1c190732bef34a79a7bdbdabbf5761

Powered by Google App Engine
This is Rietveld 408576698