DM: Draw image frames in a grid

DM: Draw image frames in a grid

Instead of drawing a large vertical strip for CodecSrc::kAnimated_Mode,
draw a grid of images. Compute the grid based on the square root of the
frame count, so the grid will be roughly square.

BUG=skia:5881
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2445863002

Committed: https://skia.googlesource.com/skia/+/90e971a41b1c190732bef34a79a7bdbdabbf5761

[scroggo_chromium, 2016-10-24 20:36:37]

Description was changed from

==========
DM: Draw image frames in a grid

Instead of drawing a large vertical strip for CodecSrc::kAnimated_Mode,
draw a grid of images. Compute the grid based on the square root of the
frame count, so the grid will be roughly square.
==========

to

==========
DM: Draw image frames in a grid

Instead of drawing a large vertical strip for CodecSrc::kAnimated_Mode,
draw a grid of images. Compute the grid based on the square root of the
frame count, so the grid will be roughly square.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2445863002
==========

[scroggo, 2016-10-24 20:37:17]

scroggo@google.com changed reviewers:
+ msarett@google.com, scroggo@google.com

[scroggo_chromium, 2016-10-24 20:41:12]

Description was changed from

==========
DM: Draw image frames in a grid

Instead of drawing a large vertical strip for CodecSrc::kAnimated_Mode,
draw a grid of images. Compute the grid based on the square root of the
frame count, so the grid will be roughly square.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2445863002
==========

to

==========
DM: Draw image frames in a grid

Instead of drawing a large vertical strip for CodecSrc::kAnimated_Mode,
draw a grid of images. Compute the grid based on the square root of the
frame count, so the grid will be roughly square.

BUG=skia:5881

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2445863002
==========

[scroggo, 2016-10-24 20:42:30]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2016-10-24 20:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 20:42:35]

This CL has an open dependency (Issue 2446543003 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[msarett1, 2016-10-24 20:46:58]

msarett@chromium.org changed reviewers:
+ msarett@chromium.org

[msarett1, 2016-10-24 20:46:59]

I disagree that this is the right way to fix the problem (vs fixing the Gold UI)
but lgtm the change.

[scroggo_chromium, 2016-10-25 12:47:01]

On 2016/10/24 20:46:59, msarett1 wrote:
> I disagree that this is the right way to fix the problem (vs fixing the Gold
UI)
> but lgtm the change.

One nice side benefit: An image with many frames, like blast.gif, shows up in
the a Gold view as completely blank, because it's so much taller than it is
wide. But this will provide a friendlier aspect ratio.

[scroggo, 2016-10-25 12:47:28]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-10-25 12:47:28]

lgtm

[commit-bot: I haz the power, 2016-10-25 12:47:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 13:11:03]

Description was changed from

==========
DM: Draw image frames in a grid

Instead of drawing a large vertical strip for CodecSrc::kAnimated_Mode,
draw a grid of images. Compute the grid based on the square root of the
frame count, so the grid will be roughly square.

BUG=skia:5881

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2445863002
==========

to

==========
DM: Draw image frames in a grid

Instead of drawing a large vertical strip for CodecSrc::kAnimated_Mode,
draw a grid of images. Compute the grid based on the square root of the
frame count, so the grid will be roughly square.

BUG=skia:5881

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2445863002

Committed:
https://skia.googlesource.com/skia/+/90e971a41b1c190732bef34a79a7bdbdabbf5761
==========

[commit-bot: I haz the power, 2016-10-25 13:11:03]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/90e971a41b1c190732bef34a79a7bdbdabbf5761