Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2446533003: Remove dead flush histograms code. (Closed)

Created:
4 years, 1 month ago by Bryan McQuade
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead flush histograms code. In https://codereview.chromium.org/2437863005, page_load_histograms, which was the only consumer of this code, was removed. Now that the page_load_histograms code has been removed, this code can be removed as well. This change is also a follow up to https://codereview.chromium.org/2231843002, which disabled histogram flushing when persistence was enabled. Now that page_load_histograms is gone, we can remove the flushing logic entirely. BUG=657993 Committed: https://crrev.com/d48284c61aefddb82c657751c59d4a32e5b4fd3c Cr-Commit-Position: refs/heads/master@{#429346}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M content/child/child_histogram_message_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/child_histogram_message_filter.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/renderer/render_thread.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/mock_render_thread.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Bryan McQuade
bcwhite, PTAL - this removes the histogram flushing code used by page_load_histograms in the render ...
4 years, 1 month ago (2016-11-02 13:56:01 UTC) #5
bcwhite
lgtm
4 years, 1 month ago (2016-11-02 17:51:06 UTC) #8
Bryan McQuade
avi, PTAL for content/ changes. Here's another change that removes dead code.
4 years, 1 month ago (2016-11-02 17:53:39 UTC) #10
Avi (use Gerrit)
lgtm all good stuff
4 years, 1 month ago (2016-11-02 17:54:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446533003/20001
4 years, 1 month ago (2016-11-02 18:09:05 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 18:19:03 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 18:23:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d48284c61aefddb82c657751c59d4a32e5b4fd3c
Cr-Commit-Position: refs/heads/master@{#429346}

Powered by Google App Engine
This is Rietveld 408576698