Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2231843002:
Don't push histograms to browser after every page load when persistence is enabled. (Closed)
DescriptionDon't push histograms to browser after every page load when persistence is enabled.
BUG=630503
TBR=thestig@chromium.org
Committed: https://crrev.com/a7742715fad96d7358b74df6b183b62765a15e63
Cr-Commit-Position: refs/heads/master@{#411079}
Patch Set 1 #
Total comments: 2
Patch Set 2 : added comment #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bcwhite@chromium.org changed reviewers: + asvitkine@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
lgtm https://codereview.chromium.org/2231843002/diff/1/chrome/renderer/page_load_h... File chrome/renderer/page_load_histograms.cc (right): https://codereview.chromium.org/2231843002/diff/1/chrome/renderer/page_load_h... chrome/renderer/page_load_histograms.cc:883: // the renderer is shutdown abruptly (e.g. the user closed the tab). Maybe add a TODO to clean this up when persistent becomes the default?
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2231843002/diff/1/chrome/renderer/page_load_h... File chrome/renderer/page_load_histograms.cc (right): https://codereview.chromium.org/2231843002/diff/1/chrome/renderer/page_load_h... chrome/renderer/page_load_histograms.cc:883: // the renderer is shutdown abruptly (e.g. the user closed the tab). On 2016/08/10 15:44:28, Alexei Svitkine (very slow) wrote: > Maybe add a TODO to clean this up when persistent becomes the default? Done.
Description was changed from ========== Don't push histograms to browser after every page load when persistence is enabled. BUG=630503 ========== to ========== Don't push histograms to browser after every page load when persistence is enabled. BUG=630503 TBR=thestig@chromium.org ==========
The CQ bit was unchecked by bcwhite@chromium.org
The CQ bit was checked by bcwhite@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/2231843002/#ps20001 (title: "added comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Don't push histograms to browser after every page load when persistence is enabled. BUG=630503 TBR=thestig@chromium.org ========== to ========== Don't push histograms to browser after every page load when persistence is enabled. BUG=630503 TBR=thestig@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Don't push histograms to browser after every page load when persistence is enabled. BUG=630503 TBR=thestig@chromium.org ========== to ========== Don't push histograms to browser after every page load when persistence is enabled. BUG=630503 TBR=thestig@chromium.org Committed: https://crrev.com/a7742715fad96d7358b74df6b183b62765a15e63 Cr-Commit-Position: refs/heads/master@{#411079} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a7742715fad96d7358b74df6b183b62765a15e63 Cr-Commit-Position: refs/heads/master@{#411079}
Message was sent while issue was closed.
thestig@chromium.org changed reviewers: + thestig@chromium.org
Message was sent while issue was closed.
rs lgtm Please actually add the people being TBR'd so they get notified. |
