Fix net::SdchSourceStream Passthrough bug

Fix net::SdchSourceStream Passthrough bug

net::SdchSourceStream handles passthrough incorrectly.
(1) When |buffered_output_| is empty, it shouldn't break early.
(2) It should write the number of bytes copied into |bytes_out|.

This CL also adds a regression test.

R=rdsmith@chromium.org

BUG=474859
Committed: https://crrev.com/d49eb584a73cb1d96cf1efb05ff839376340cfe1
Cr-Commit-Position: refs/heads/master@{#427345}

[xunjieli, 2016-10-21 21:24:08]

Description was changed from

==========
Fix net::SdchSourceStream Passthrough bug

net::SdchSourceStream handles passthrough incorrectly.
(1) When |buffered_output_| is empty, it shouldn't break early.
(2) It should write the number of bytes copied into |bytes_out|.

This CL also adds a regression test.

R=rdsmith@chromium.org
BUG=474859
==========

to

==========
Fix net::SdchSourceStream Passthrough bug

net::SdchSourceStream handles passthrough incorrectly.
(1) When |buffered_output_| is empty, it shouldn't break early.
(2) It should write the number of bytes copied into |bytes_out|.

This CL also adds a regression test.

R=rdsmith@chromium.org

BUG=474859
==========

[xunjieli, 2016-10-21 21:24:45]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[xunjieli, 2016-10-21 21:25:35]

Hi Randy, I made some really stupid mistakes in my last CL. This should fix it.
Sorry about that. I added regression test. PTAL.

[commit-bot: I haz the power, 2016-10-21 21:25:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2016-10-21 21:26:55]

On 2016/10/21 21:25:35, xunjieli wrote:
> Hi Randy, I made some really stupid mistakes in my last CL. This should fix
it.
> Sorry about that. I added regression test. PTAL.

Forgot to say that the issue wasn't in the order of filters. It was just a bug
in the pass-through logic, and I got confused during debugging..

[commit-bot: I haz the power, 2016-10-21 22:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:22:00]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Randy Smith (Not in Mondays), 2016-10-23 01:32:07]

https://codereview.chromium.org/2446443002/diff/1/net/filter/sdch_source_stre...
File net/filter/sdch_source_stream.cc (right):

https://codereview.chromium.org/2446443002/diff/1/net/filter/sdch_source_stre...
net/filter/sdch_source_stream.cc:145: if (buffered_output_.empty()) {
Isn't this inverted?  Don't you want to FlushBufferedOutput() if
buffered_output_ is *not* empty?

[xunjieli, 2016-10-24 11:58:02]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 11:58:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2016-10-24 11:58:58]

https://codereview.chromium.org/2446443002/diff/1/net/filter/sdch_source_stre...
File net/filter/sdch_source_stream.cc (right):

https://codereview.chromium.org/2446443002/diff/1/net/filter/sdch_source_stre...
net/filter/sdch_source_stream.cc:145: if (buffered_output_.empty()) {
On 2016/10/23 01:32:07, Randy Smith - Not in Mondays wrote:
> Isn't this inverted?  Don't you want to FlushBufferedOutput() if
> buffered_output_ is *not* empty?

Sorry, I tried to split the change off the switch-over CL and didn't realize
this is inverted. The test I added should catch this.

[commit-bot: I haz the power, 2016-10-24 14:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 14:36:08]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2016-10-25 12:30:58]

lgtm

[xunjieli, 2016-10-25 13:34:13]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-10-25 13:34:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 14:25:37]

Description was changed from

==========
Fix net::SdchSourceStream Passthrough bug

net::SdchSourceStream handles passthrough incorrectly.
(1) When |buffered_output_| is empty, it shouldn't break early.
(2) It should write the number of bytes copied into |bytes_out|.

This CL also adds a regression test.

R=rdsmith@chromium.org

BUG=474859
==========

to

==========
Fix net::SdchSourceStream Passthrough bug

net::SdchSourceStream handles passthrough incorrectly.
(1) When |buffered_output_| is empty, it shouldn't break early.
(2) It should write the number of bytes copied into |bytes_out|.

This CL also adds a regression test.

R=rdsmith@chromium.org

BUG=474859
==========

[commit-bot: I haz the power, 2016-10-25 14:25:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 14:27:17]

Description was changed from

==========
Fix net::SdchSourceStream Passthrough bug

net::SdchSourceStream handles passthrough incorrectly.
(1) When |buffered_output_| is empty, it shouldn't break early.
(2) It should write the number of bytes copied into |bytes_out|.

This CL also adds a regression test.

R=rdsmith@chromium.org

BUG=474859
==========

to

==========
Fix net::SdchSourceStream Passthrough bug

net::SdchSourceStream handles passthrough incorrectly.
(1) When |buffered_output_| is empty, it shouldn't break early.
(2) It should write the number of bytes copied into |bytes_out|.

This CL also adds a regression test.

R=rdsmith@chromium.org

BUG=474859

Committed: https://crrev.com/d49eb584a73cb1d96cf1efb05ff839376340cfe1
Cr-Commit-Position: refs/heads/master@{#427345}
==========

[commit-bot: I haz the power, 2016-10-25 14:27:18]

Patchset 2 (id:??) landed as
https://crrev.com/d49eb584a73cb1d96cf1efb05ff839376340cfe1
Cr-Commit-Position: refs/heads/master@{#427345}