Fix net::SdchSourceStream Passthrough bug

net/filter/sdch_source_stream.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/filter/sdch_source_stream.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
@@ skipping 124 matching lines @@
       }
       case STATE_OUTPUT_REPLACE: {
         int flushed = FlushBufferedOutput(output_buffer->data() + bytes_out,
                                           output_buffer_size - bytes_out,
                                           buffered_output_);
         buffered_output_.erase(0, flushed);
         bytes_out += flushed;
         break;
       }
       case STATE_PASS_THROUGH: {
-        if (buffered_output_.empty())
-          break;
-        int flushed = FlushBufferedOutput(output_buffer->data() + bytes_out,
-                                          output_buffer_size - bytes_out,
-                                          buffered_output_);
-        buffered_output_.erase(0, flushed);
-        bytes_out += flushed;
+        if (buffered_output_.empty()) {

[Randy Smith (Not in Mondays), 2016/10/23 01:32:07]

Isn't this inverted?  Don't you want to FlushBufferedOutput() if
buffered_output_ is *not* empty?

[xunjieli, 2016/10/24 11:58:58]

Sorry, I tried to split the change off the switch-over CL and didn't realize
this is inverted. The test I added should catch this.

+          int flushed = FlushBufferedOutput(output_buffer->data() + bytes_out,
+                                            output_buffer_size - bytes_out,
+                                            buffered_output_);
+          buffered_output_.erase(0, flushed);
+          bytes_out += flushed;
+        }
         if (!buffered_output_.empty())
           break;
         size_t to_copy =
             std::min(output_buffer_size - bytes_out, input_data_size);
         memcpy(output_buffer->data() + bytes_out, input_data, to_copy);
+        bytes_out += to_copy;
         input_data += to_copy;
         input_data_size -= to_copy;
         break;
       }
     }
   }
   *consumed_bytes = input_buffer_size - input_data_size;
   return bytes_out;
 }
 
@@ skipping 16 matching lines @@
       input_state_ = STATE_PASS_THROUGH;
       break;
     case Delegate::REPLACE_OUTPUT:
       input_state_ = STATE_OUTPUT_REPLACE;
       break;
   }
   return true;
 }
 
 }  // namespace net