chromeos: Fix renderer-freezing race during aborted suspend.

chromeos: Fix renderer-freezing race during aborted suspend.

Fix a (long-standing?) race where
chromeos::PowerManagerClient could notify RendererFreezer
that a suspend attempt was imminent *after* already telling
it that the attempt was done.

Also make PowerManagerClient not notify powerd about regular
or dark suspend readiness after it's already seen a
SuspendDone signal.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=646912
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2340153002
Cr-Commit-Position: refs/heads/master@{#418887}
(cherry picked from commit 7e1b5a3c7d7ae30ed6ff862f6257ec617da9d742)

[Daniel Erat, 2016-10-25 23:19:43]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:20:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 23:20:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:20:30]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Daniel Erat, 2016-10-25 23:24:05]

derat@chromium.org changed reviewers:
+ chirantan@chromium.org

[chirantan, 2016-10-25 23:24:57]

chirantan@google.com changed reviewers:
+ chirantan@google.com

[chirantan, 2016-10-25 23:24:58]

lgtm

lgtm

[Chirantan Ekbote, 2016-10-25 23:25:46]

lgtm

From the right account this time

[Daniel Erat, 2016-10-25 23:27:59]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:28:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 23:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:28:31]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[Daniel Erat, 2016-10-25 23:30:23]

Description was changed from

==========
chromeos: Fix renderer-freezing race during aborted suspend.

Fix a (long-standing?) race where
chromeos::PowerManagerClient could notify RendererFreezer
that a suspend attempt was imminent *after* already telling
it that the attempt was done.

Also make PowerManagerClient not notify powerd about regular
or dark suspend readiness after it's already seen a
SuspendDone signal.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=646912
Review-Url: https://codereview.chromium.org/2340153002
Cr-Commit-Position: refs/heads/master@{#418887}
(cherry picked from commit 7e1b5a3c7d7ae30ed6ff862f6257ec617da9d742)
==========

to

==========
chromeos: Fix renderer-freezing race during aborted suspend.

Fix a (long-standing?) race where
chromeos::PowerManagerClient could notify RendererFreezer
that a suspend attempt was imminent *after* already telling
it that the attempt was done.

Also make PowerManagerClient not notify powerd about regular
or dark suspend readiness after it's already seen a
SuspendDone signal.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=646912
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2340153002
Cr-Commit-Position: refs/heads/master@{#418887}
(cherry picked from commit 7e1b5a3c7d7ae30ed6ff862f6257ec617da9d742)
==========

[Daniel Erat, 2016-10-25 23:30:28]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:30:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 23:37:15]

Description was changed from

==========
chromeos: Fix renderer-freezing race during aborted suspend.

Fix a (long-standing?) race where
chromeos::PowerManagerClient could notify RendererFreezer
that a suspend attempt was imminent *after* already telling
it that the attempt was done.

Also make PowerManagerClient not notify powerd about regular
or dark suspend readiness after it's already seen a
SuspendDone signal.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=646912
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2340153002
Cr-Commit-Position: refs/heads/master@{#418887}
(cherry picked from commit 7e1b5a3c7d7ae30ed6ff862f6257ec617da9d742)
==========

to

==========
chromeos: Fix renderer-freezing race during aborted suspend.

Fix a (long-standing?) race where
chromeos::PowerManagerClient could notify RendererFreezer
that a suspend attempt was imminent *after* already telling
it that the attempt was done.

Also make PowerManagerClient not notify powerd about regular
or dark suspend readiness after it's already seen a
SuspendDone signal.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=646912
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2340153002
Cr-Commit-Position: refs/heads/master@{#418887}
(cherry picked from commit 7e1b5a3c7d7ae30ed6ff862f6257ec617da9d742)
==========

[commit-bot: I haz the power, 2016-10-25 23:37:16]

Committed patchset #1 (id:1)