Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2340153002: chromeos: Fix renderer-freezing race during aborted suspend. (Closed)

Created:
4 years, 3 months ago by Daniel Erat
Modified:
4 years, 3 months ago
Reviewers:
Chirantan Ekbote
CC:
chromium-reviews, oshima+watch_chromium.org, derat+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Fix renderer-freezing race during aborted suspend. Fix a (long-standing?) race where chromeos::PowerManagerClient could notify RendererFreezer that a suspend attempt was imminent *after* already telling it that the attempt was done. Also make PowerManagerClient not notify powerd about regular or dark suspend readiness after it's already seen a SuspendDone signal. Add a bunch of unit tests exercising this code, too, and rework the comments on some previously-added tests. BUG=646912 Committed: https://crrev.com/7e1b5a3c7d7ae30ed6ff862f6257ec617da9d742 Cr-Commit-Position: refs/heads/master@{#418887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -21 lines) Patch
M chromeos/dbus/power_manager_client.cc View 4 chunks +23 lines, -6 lines 0 comments Download
M chromeos/dbus/power_manager_client_unittest.cc View 8 chunks +156 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Daniel Erat
4 years, 3 months ago (2016-09-15 00:21:40 UTC) #4
Chirantan Ekbote
lgtm
4 years, 3 months ago (2016-09-15 16:38:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340153002/1
4 years, 3 months ago (2016-09-15 16:45:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 16:50:52 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:10:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e1b5a3c7d7ae30ed6ff862f6257ec617da9d742
Cr-Commit-Position: refs/heads/master@{#418887}

Powered by Google App Engine
This is Rietveld 408576698