Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2446403004: NGPhysicalFragment implementation to cc file (Closed)

Created:
4 years, 1 month ago by atotic
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NGPhysicalFragment implementation to cc file absrel patch will add more interesting methods to NGPhysicalFragment Moving implementation to file prepares us for future methods BUG=635619 Committed: https://crrev.com/347328c6573d9d46b61b668d2118a0e71bf83ed6 Cr-Commit-Position: refs/heads/master@{#427766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 3 chunks +2 lines, -10 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
atotic
ptal
4 years, 1 month ago (2016-10-26 05:26:00 UTC) #2
eae
OK, LGTM
4 years, 1 month ago (2016-10-26 17:01:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446403004/1
4 years, 1 month ago (2016-10-26 17:02:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 18:55:30 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 19:22:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/347328c6573d9d46b61b668d2118a0e71bf83ed6
Cr-Commit-Position: refs/heads/master@{#427766}

Powered by Google App Engine
This is Rietveld 408576698