Milo: Fix issues with expiring builds due to builder disappearing

Milo: Fix issues with expiring builds due to builder disappearing

BUG=654623
TBR=estaab

[Ryan Tseng, 2016-10-27 01:30:23]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 01:30:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-10-27 01:31:13]

Description was changed from

==========
Milo: Fix issues with expiring builds due to builder disappearing

BUG=
==========

to

==========
Milo: Fix issues with expiring builds due to builder disappearing

BUG= 654623
==========

[hinoka, 2016-10-27 01:31:13]

hinoka@chromium.org changed reviewers:
+ estaab@chromium.org

[hinoka, 2016-10-27 01:31:22]

hinoka@chromium.org changed reviewers:
+ hinoka@chromium.org

[hinoka, 2016-10-27 01:31:23]

ptal, 1 line change.

https://codereview.chromium.org/2446273005/diff/1/milo/appengine/buildbot/pub...
File milo/appengine/buildbot/pubsub.go (right):

https://codereview.chromium.org/2446273005/diff/1/milo/appengine/buildbot/pub...
milo/appengine/buildbot/pubsub.go:240: continue
Continue because we're done with this build

https://codereview.chromium.org/2446273005/diff/1/milo/appengine/buildbot/pub...
milo/appengine/buildbot/pubsub.go:244: for _, bnum := range
builder.CurrentBuilds {
builder is nil here otherwise.

[commit-bot: I haz the power, 2016-10-27 02:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 02:06:05]

Dry run: Try jobs failed on following builders:
  Luci-go Win Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/321c94424db0b010)

[hinoka, 2016-11-11 20:06:13]

Description was changed from

==========
Milo: Fix issues with expiring builds due to builder disappearing

BUG= 654623
==========

to

==========
Milo: Fix issues with expiring builds due to builder disappearing

BUG= 654623
TBR=estaab
==========

[hinoka, 2016-11-11 20:06:17]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:06:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:09:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:09:36]

Try jobs failed on following builders:
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/326dd14be42a9410)

[hinoka, 2016-11-14 21:25:20]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2016-11-14 21:25:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 21:29:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 21:29:15]

Try jobs failed on following builders:
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/327d8cabc4294a10)