milo/appengine/buildbot/pubsub.go - Issue 2446273005: Milo: Fix issues with expiring builds due to builder disappearing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/buildbot/pubsub.go

Issue 2446273005: Milo: Fix issues with expiring builds due to builder disappearing (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/appengine/buildbot/pubsub.go

diff --git a/milo/appengine/buildbot/pubsub.go b/milo/appengine/buildbot/pubsub.go

index ad6a63cd588d61eae96ca86f239ce3ad1bf779fe..afd24d9f6215bff0a3e876e006acbed6d1b27d26 100644

--- a/milo/appengine/buildbot/pubsub.go

+++ b/milo/appengine/buildbot/pubsub.go

@@ -237,6 +237,7 @@ func doMaster(c context.Context, master *buildbotMaster, internal bool) int {

logging.WithError(err).Errorf(c, "Could not expire build")

return 500

}

+ continue

hinoka 2016/10/27 01:31:22 Continue because we're done with this build

}

found := false

« no previous file with comments | « no previous file | no next file » | no next file with comments »