Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 244623003: [fsp] [recommit] Add FileSystemURLParser to the file system provider. (Closed)

Created:
6 years, 8 months ago by mtomasz
Modified:
6 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[fsp] [recommit] Add FileSystemURLParser to the file system provider. The FileSystemURLParser is a class which parses a cracked FileSystemURL to associate it with the proper ProvidedFileSystem class handling this URL. This will be necessary to route operations from AsyncFileUtil to a proper providing extension. Along the way, the Service class has been fixed. Now, the provided file systems are gracefully unmounted in destructor. As a result, the external mount points are cleared neatly. Previously reverted, because depending on a CL to be reverted. See: https://codereview.chromium.org/237583015 TBR=kinaba@chromium.org TEST=unit_tests: FileSystemProviderMountPathUtilTest* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264975

Patch Set 1 #

Patch Set 2 : Rebased. #

Messages

Total messages: 13 (0 generated)
mtomasz
@kinaba: TBR. This is the same as https://codereview.chromium.org/237583015, but with a rebase. This CL got ...
6 years, 8 months ago (2014-04-21 04:15:47 UTC) #1
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-21 04:15:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/244623003/1
6 years, 8 months ago (2014-04-21 04:15:56 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 04:15:57 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-21 04:15:57 UTC) #5
kinaba
lgtm
6 years, 8 months ago (2014-04-21 04:17:45 UTC) #6
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-21 04:17:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/244623003/1
6 years, 8 months ago (2014-04-21 04:17:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 05:49:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-21 05:49:42 UTC) #10
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-21 07:18:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/244623003/20001
6 years, 8 months ago (2014-04-21 07:18:40 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-21 10:37:05 UTC) #13
Message was sent while issue was closed.
Change committed as 264975

Powered by Google App Engine
This is Rietveld 408576698