Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 237583015: [fsp] Add FileSystemURLParser to the file system provider. (Closed)

Created:
6 years, 8 months ago by mtomasz
Modified:
6 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

[fsp] Add FileSystemURLParser to the file system provider. The FileSystemURLParser is a class which parses a cracked FileSystemURL to associate it with the proper ProvidedFileSystem class handling this URL. This will be necessary to route operations from AsyncFileUtil to a proper providing extension. Along the way, the Service class has been fixed. Now, the provided file systems are gracefully unmounted in destructor. As a result, the external mount points are cleared neatly. TEST=unit_tests: FileSystemProviderMountPathUtilTest* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264780

Patch Set 1 #

Patch Set 2 : Fixed tests. #

Total comments: 2

Patch Set 3 : Simplified. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -35 lines) Patch
M chrome/browser/chromeos/file_system_provider/mount_path_util.h View 1 chunk +33 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/mount_path_util.cc View 1 3 chunks +60 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc View 1 chunk +115 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.h View 4 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.cc View 1 2 8 chunks +43 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@kinaba: PTAL. Thanks!
6 years, 8 months ago (2014-04-17 06:28:49 UTC) #1
kinaba
lgtm with a nit https://codereview.chromium.org/237583015/diff/20001/chrome/browser/chromeos/file_system_provider/service.cc File chrome/browser/chromeos/file_system_provider/service.cc (right): https://codereview.chromium.org/237583015/diff/20001/chrome/browser/chromeos/file_system_provider/service.cc#newcode188 chrome/browser/chromeos/file_system_provider/service.cc:188: mount_point_name_to_id_map_.erase(mapping_it); Simply mount_point_name_to_id_map_.erase(mount_point_name);
6 years, 8 months ago (2014-04-18 05:51:30 UTC) #2
mtomasz
https://codereview.chromium.org/237583015/diff/20001/chrome/browser/chromeos/file_system_provider/service.cc File chrome/browser/chromeos/file_system_provider/service.cc (right): https://codereview.chromium.org/237583015/diff/20001/chrome/browser/chromeos/file_system_provider/service.cc#newcode188 chrome/browser/chromeos/file_system_provider/service.cc:188: mount_point_name_to_id_map_.erase(mapping_it); On 2014/04/18 05:51:30, kinaba wrote: > Simply > ...
6 years, 8 months ago (2014-04-18 06:56:00 UTC) #3
mtomasz
6 years, 8 months ago (2014-04-18 06:56:01 UTC) #4
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-18 06:56:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/237583015/40001
6 years, 8 months ago (2014-04-18 06:56:20 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 13:02:00 UTC) #7
Message was sent while issue was closed.
Change committed as 264780

Powered by Google App Engine
This is Rietveld 408576698