Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2446113005: Avoid dubious use of comma operator in fde_csssyntax.h (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid dubious use of comma operator in fde_csssyntax.h Committed: https://pdfium.googlesource.com/pdfium/+/530c7acf7aa11ff8db8743af0d62b39cf36bf539

Patch Set 1 #

Patch Set 2 : FX_BOOL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M xfa/fde/css/fde_csssyntax.h View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom Sepez
npm, quick review.
4 years, 1 month ago (2016-10-25 21:08:22 UTC) #2
npm
lgtm, assuming it passes win_xfa bot...
4 years, 1 month ago (2016-10-25 21:11:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446113005/20001
4 years, 1 month ago (2016-10-25 21:28:41 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:36:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/530c7acf7aa11ff8db8743af0d62b39cf36b...

Powered by Google App Engine
This is Rietveld 408576698