Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: xfa/fde/css/fde_csssyntax.h

Issue 2446113005: Avoid dubious use of comma operator in fde_csssyntax.h (Closed)
Patch Set: FX_BOOL Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fde/css/fde_csssyntax.h
diff --git a/xfa/fde/css/fde_csssyntax.h b/xfa/fde/css/fde_csssyntax.h
index 294dfcb54002306236dc6674e73e2075fe4c528e..af1d444144cd76820680af542864c110bc05cba0 100644
--- a/xfa/fde/css/fde_csssyntax.h
+++ b/xfa/fde/css/fde_csssyntax.h
@@ -22,11 +22,11 @@ class CFDE_CSSTextBuf : public CFX_Target {
int32_t iStreamOffset,
int32_t iMaxChars,
FX_BOOL& bEOS);
- FX_BOOL AppendChar(FX_WCHAR wch) {
- if (m_iDatLen >= m_iBufLen && !ExpandBuf(m_iBufLen * 2)) {
- return FALSE;
- }
- return (m_pBuffer[m_iDatLen++] = wch), TRUE;
+ bool AppendChar(FX_WCHAR wch) {
+ if (m_iDatLen >= m_iBufLen && !ExpandBuf(m_iBufLen * 2))
+ return false;
+ m_pBuffer[m_iDatLen++] = wch;
+ return true;
}
void Clear() { m_iDatPos = m_iDatLen = 0; }
void Reset();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698