Issue 2446093002: Use ZoneHandle when creating ConstantInstr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2446093002: Use ZoneHandle when creating ConstantInstr (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)

Modified:
3 years, 10 months ago

Reviewers:
Florian Schneider, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use ZoneHandle when creating ConstantInstr BUG= TBR=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/cb87f2d82fc8b4dab02e994361e97ed13c9859b8

Patch Set 1 #

Total comments: 1

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Vyacheslav Egorov (Google)

Committed patchset #1 (id:1) manually as cb87f2d82fc8b4dab02e994361e97ed13c9859b8 (presubmit successful).

4 years, 1 month ago (2016-10-25 09:15:17 UTC) #3

siva

4 years, 1 month ago (2016-10-25 10:42:32 UTC) #5

Message was sent while issue was closed.

DBC.

https://codereview.chromium.org/2446093002/diff/1/runtime/vm/flow_graph_inlin...
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/2446093002/diff/1/runtime/vm/flow_graph_inlin...
runtime/vm/flow_graph_inliner.cc:3836: *last = new(Z)
ConstantInstr(Type::ZoneHandle(Z, type.raw()));
The type handle seems to be created above, would it make sense to create it as a
ZoneHandle in the first place over there?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages