Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: runtime/vm/flow_graph_inliner.cc

Issue 2446093002: Use ZoneHandle when creating ConstantInstr (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_inliner.h" 5 #include "vm/flow_graph_inliner.h"
6 6
7 #include "vm/aot_optimizer.h" 7 #include "vm/aot_optimizer.h"
8 #include "vm/block_scheduler.h" 8 #include "vm/block_scheduler.h"
9 #include "vm/branch_optimizer.h" 9 #include "vm/branch_optimizer.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 3815 matching lines...) Expand 10 before | Expand all | Expand 10 after
3826 flow_graph->isolate()->class_table()->At(receiver_cid)); 3826 flow_graph->isolate()->class_table()->At(receiver_cid));
3827 if (!cls.IsGeneric()) { 3827 if (!cls.IsGeneric()) {
3828 type = cls.CanonicalType(); 3828 type = cls.CanonicalType();
3829 } 3829 }
3830 } 3830 }
3831 3831
3832 if (!type.IsNull()) { 3832 if (!type.IsNull()) {
3833 *entry = new(Z) TargetEntryInstr(flow_graph->allocate_block_id(), 3833 *entry = new(Z) TargetEntryInstr(flow_graph->allocate_block_id(),
3834 call->GetBlock()->try_index()); 3834 call->GetBlock()->try_index());
3835 (*entry)->InheritDeoptTarget(Z, call); 3835 (*entry)->InheritDeoptTarget(Z, call);
3836 *last = new(Z) ConstantInstr(type); 3836 *last = new(Z) ConstantInstr(Type::ZoneHandle(Z, type.raw()));
siva 2016/10/25 10:42:32 The type handle seems to be created above, would i
3837 flow_graph->AppendTo(*entry, *last, 3837 flow_graph->AppendTo(*entry, *last,
3838 call->deopt_id() != Thread::kNoDeoptId ? 3838 call->deopt_id() != Thread::kNoDeoptId ?
3839 call->env() : NULL, 3839 call->env() : NULL,
3840 FlowGraph::kValue); 3840 FlowGraph::kValue);
3841 return true; 3841 return true;
3842 } 3842 }
3843 return false; 3843 return false;
3844 } 3844 }
3845 3845
3846 case MethodRecognizer::kOneByteStringSetAt: { 3846 case MethodRecognizer::kOneByteStringSetAt: {
(...skipping 22 matching lines...) Expand all
3869 return true; 3869 return true;
3870 } 3870 }
3871 3871
3872 default: 3872 default:
3873 return false; 3873 return false;
3874 } 3874 }
3875 } 3875 }
3876 3876
3877 3877
3878 } // namespace dart 3878 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698