Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2445993005: Add histogram definitions for Chrome OS boot mode. (Closed)

Created:
4 years, 1 month ago by Mattias Nissler (ping if slow)
Modified:
4 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histogram definitions for Chrome OS boot mode. This adds enum type definitions and histogram declarations for boot mode metrics recorded by the Chrome OS boot process. See also https://chromium-review.googlesource.com/#/c/400739 BUG=chromium:658207 TEST=None Committed: https://crrev.com/64815089e2fbe13e92661d8c81d7c6c05c6b172e Cr-Commit-Position: refs/heads/master@{#428670}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use histogram suffixes for firmware types. #

Patch Set 3 : Shorten suffix name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 3 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Mattias Nissler (ping if slow)
4 years, 1 month ago (2016-10-27 10:57:10 UTC) #2
Ilya Sherman
LGTM https://codereview.chromium.org/2445993005/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2445993005/diff/1/tools/metrics/histograms/histograms.xml#newcode43062 tools/metrics/histograms/histograms.xml:43062: +</histogram> nit: Maybe use a histogram_suffixes element to ...
4 years, 1 month ago (2016-10-28 02:24:07 UTC) #7
Mattias Nissler (ping if slow)
Switched to use suffixes. Still looks good? https://codereview.chromium.org/2445993005/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2445993005/diff/1/tools/metrics/histograms/histograms.xml#newcode43062 tools/metrics/histograms/histograms.xml:43062: +</histogram> On ...
4 years, 1 month ago (2016-10-28 11:53:09 UTC) #8
Ilya Sherman
LGTM
4 years, 1 month ago (2016-10-28 18:30:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445993005/40001
4 years, 1 month ago (2016-10-28 18:31:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/292205)
4 years, 1 month ago (2016-10-28 20:34:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445993005/40001
4 years, 1 month ago (2016-10-31 08:56:30 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-31 09:49:55 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 09:51:47 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64815089e2fbe13e92661d8c81d7c6c05c6b172e
Cr-Commit-Position: refs/heads/master@{#428670}

Powered by Google App Engine
This is Rietveld 408576698