Chromium Code Reviews Chromium Code Reviews
Issue 2445993005:
Add histogram definitions for Chrome OS boot mode. (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index eae5a18e985d0ff817e9c25b27a05d7446412a86..6c212a719f48ce8e2b02f120d9ee704027e9c9cb 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -43025,6 +43025,51 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Platform.BootMode.DevSwitch" |
| + enum="Platform.BootMode.SwitchStatus"> |
| + <owner>mnissler@chromium.org</owner> |
| + <summary> |
| + Indicates the status of the developer switch on Chrome OS hardware. The |
| + developer switch allows users to run their own code on the device. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Platform.BootMode.FirmwareWriteProtect.EC" |
| + enum="Platform.BootMode.FirmwareWriteProtect"> |
| + <owner>mnissler@chromium.org</owner> |
| + <summary> |
| + On Chrome OS hardware, indicates whether flash write protection is enabled |
| + for the embedded controller firmware. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Platform.BootMode.FirmwareWriteProtect.Main" |
| + enum="Platform.BootMode.FirmwareWriteProtect"> |
| + <owner>mnissler@chromium.org</owner> |
| + <summary> |
| + On Chrome OS hardware, indicates whether flash write protection is enabled |
| + for the main processor firmware. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Platform.BootMode.FirmwareWriteProtect.PD" |
| + enum="Platform.BootMode.FirmwareWriteProtect"> |
| + <owner>mnissler@chromium.org</owner> |
| + <summary> |
| + On Chrome OS hardware, indicates whether flash write protection is enabled |
| + for the USB Power Delivery controller firmware. |
| + </summary> |
| +</histogram> |
|
Ilya Sherman
2016/10/28 02:24:07
nit: Maybe use a histogram_suffixes element to red
Mattias Nissler (ping if slow)
2016/10/28 11:53:09
Done.
|
| + |
| +<histogram name="Platform.BootMode.WriteProtectSwitch" |
| + enum="Platform.BootMode.SwitchStatus"> |
| + <owner>mnissler@chromium.org</owner> |
| + <summary> |
| + Indicates the status of the hardware write protect switch on Chrome OS |
| + hardware. The write protect switch protects firmware from being rewritten. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Platform.BootSectorsRead"> |
| <owner>sonnyrao@chromium.org</owner> |
| <summary> |
| @@ -95202,6 +95247,19 @@ value. |
| <int value="20" label="AUDIO_RENDERER_ERROR_SPLICE_FAILED"/> |
| </enum> |
| +<enum name="Platform.BootMode.FirmwareWriteProtect" type="int"> |
| + <int value="0" label="Off"/> |
| + <int value="1" label="On"/> |
| + <int value="2" label="Zero length range"/> |
| + <int value="3" label="Error"/> |
| +</enum> |
| + |
| +<enum name="Platform.BootMode.SwitchStatus" type="int"> |
| + <int value="0" label="Off"/> |
| + <int value="1" label="On"/> |
| + <int value="2" label="Error"/> |
| +</enum> |
| + |
| <enum name="PlatformFileError" type="int"> |
| <int value="0" label="OK"/> |
| <int value="1" label="FAILED"/> |
