Drop unused end-position from VariableProxy

Drop unused end-position from VariableProxy

BUG=

Committed: https://crrev.com/26a5f2128bb99510793afff6fe460621ed62c23c
Cr-Commit-Position: refs/heads/master@{#40548}

[Toon Verwaest, 2016-10-24 23:44:33]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 23:44:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 00:50:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:50:55]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-10-25 07:06:12]

verwaest@chromium.org changed reviewers:
+ adamk@chromium.org

[Toon Verwaest, 2016-10-25 07:06:12]

ptal

[adamk, 2016-10-25 07:11:30]

lgtm with a question and a possible small extra deletion.

https://codereview.chromium.org/2445993002/diff/1/src/ast/ast.h
File src/ast/ast.h (left):

https://codereview.chromium.org/2445993002/diff/1/src/ast/ast.h#oldcode1682
src/ast/ast.h:1682: int end_position() const { return end_position_; }
How long ago did the callers of this die?

https://codereview.chromium.org/2445993002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (left):

https://codereview.chromium.org/2445993002/diff/1/src/parsing/parser.cc#oldco...
src/parsing/parser.cc:2016: for_info->each_loc.end_pos);
You could now change ForInfo to store an "int position" instead of a
Scanner::Location.

[Toon Verwaest, 2016-10-25 07:25:15]

Addressed comment. Very nice!

https://codereview.chromium.org/2445993002/diff/1/src/ast/ast.h
File src/ast/ast.h (left):

https://codereview.chromium.org/2445993002/diff/1/src/ast/ast.h#oldcode1682
src/ast/ast.h:1682: int end_position() const { return end_position_; }
On 2016/10/25 07:11:30, adamk wrote:
> How long ago did the callers of this die?

No idea to be honest. The comment scarily suggests it's *necessary*, which is
probably why it was overlooked so often.

https://codereview.chromium.org/2445993002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (left):

https://codereview.chromium.org/2445993002/diff/1/src/parsing/parser.cc#oldco...
src/parsing/parser.cc:2016: for_info->each_loc.end_pos);
On 2016/10/25 07:11:30, adamk wrote:
> You could now change ForInfo to store an "int position" instead of a
> Scanner::Location.

Nice!

[Toon Verwaest, 2016-10-25 07:27:34]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-10-25 07:27:34]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2445993002/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-10-25 07:27:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 07:59:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:11:54]

Description was changed from

==========
Drop unused end-position from VariableProxy

BUG=
==========

to

==========
Drop unused end-position from VariableProxy

BUG=

Committed: https://crrev.com/26a5f2128bb99510793afff6fe460621ed62c23c
Cr-Commit-Position: refs/heads/master@{#40548}
==========

[commit-bot: I haz the power, 2016-11-17 22:11:55]

Patchset 2 (id:??) landed as
https://crrev.com/26a5f2128bb99510793afff6fe460621ed62c23c
Cr-Commit-Position: refs/heads/master@{#40548}