Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: src/ast/ast.cc

Issue 2445993002: Drop unused end-position from VariableProxy (Closed)
Patch Set: Addressed comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.h ('k') | src/ast/scopes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.cc
diff --git a/src/ast/ast.cc b/src/ast/ast.cc
index 9db91e2b9cd774d7abd5f3f0c6bb073f3ac5b9a6..530bd50aaf7e12fadf6860b241663b594c5c514c 100644
--- a/src/ast/ast.cc
+++ b/src/ast/ast.cc
@@ -159,10 +159,8 @@ bool Statement::IsJump() const {
}
}
-VariableProxy::VariableProxy(Variable* var, int start_position,
- int end_position)
+VariableProxy::VariableProxy(Variable* var, int start_position)
: Expression(start_position, kVariableProxy),
- end_position_(end_position),
raw_name_(var->raw_name()),
next_unresolved_(nullptr) {
bit_field_ |= IsThisField::encode(var->is_this()) |
@@ -173,10 +171,8 @@ VariableProxy::VariableProxy(Variable* var, int start_position,
}
VariableProxy::VariableProxy(const AstRawString* name,
- VariableKind variable_kind, int start_position,
- int end_position)
+ VariableKind variable_kind, int start_position)
: Expression(start_position, kVariableProxy),
- end_position_(end_position),
raw_name_(name),
next_unresolved_(nullptr) {
bit_field_ |= IsThisField::encode(variable_kind == THIS_VARIABLE) |
@@ -187,7 +183,6 @@ VariableProxy::VariableProxy(const AstRawString* name,
VariableProxy::VariableProxy(const VariableProxy* copy_from)
: Expression(copy_from->position(), kVariableProxy),
- end_position_(copy_from->end_position_),
next_unresolved_(nullptr) {
bit_field_ = copy_from->bit_field_;
DCHECK(!copy_from->is_resolved());
« no previous file with comments | « src/ast/ast.h ('k') | src/ast/scopes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698