Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2445923002: [Devtools] Cleanup DataGrid.js (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @param {!WebInspector.NetworkLogView} networkLogView 7 * @param {!WebInspector.NetworkLogView} networkLogView
8 * @param {!WebInspector.Setting} networkLogLargeRowsSetting 8 * @param {!WebInspector.Setting} networkLogLargeRowsSetting
9 */ 9 */
10 WebInspector.NetworkLogViewColumns = function(networkLogView, networkLogLargeRow sSetting) 10 WebInspector.NetworkLogViewColumns = function(networkLogView, networkLogLargeRow sSetting)
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 subtitleDiv.createTextChild(subtitle); 579 subtitleDiv.createTextChild(subtitle);
580 return fragment; 580 return fragment;
581 }, 581 },
582 582
583 /** 583 /**
584 * @param {!Event} event 584 * @param {!Event} event
585 * @return {boolean} 585 * @return {boolean}
586 */ 586 */
587 contextMenu: function(event) 587 contextMenu: function(event)
588 { 588 {
589 if (!this._gridMode || !event.target.isSelfOrDescendant(this._dataGrid.h eaderTableBody)) 589 if (!this._gridMode || !event.target.isSelfOrDescendant(this._dataGrid.h eaderTableBody()))
590 return false; 590 return false;
591 591
592 var columnConfigs = this._columns.filter(columnConfig => columnConfig.hi deable); 592 var columnConfigs = this._columns.filter(columnConfig => columnConfig.hi deable);
593 var contextMenu = new WebInspector.ContextMenu(event); 593 var contextMenu = new WebInspector.ContextMenu(event);
594 var nonResponseHeaders = columnConfigs.filter(columnConfig => !columnCon fig.isResponseHeader); 594 var nonResponseHeaders = columnConfigs.filter(columnConfig => !columnCon fig.isResponseHeader);
595 for (var columnConfig of nonResponseHeaders) 595 for (var columnConfig of nonResponseHeaders)
596 contextMenu.appendCheckboxItem(columnConfig.title, this._toggleColum nVisibility.bind(this, columnConfig), columnConfig.visible); 596 contextMenu.appendCheckboxItem(columnConfig.title, this._toggleColum nVisibility.bind(this, columnConfig), columnConfig.visible);
597 597
598 contextMenu.appendSeparator(); 598 contextMenu.appendSeparator();
599 599
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 divider.element.classList.toggle("network-frame-divider-selected", f alse); 831 divider.element.classList.toggle("network-frame-divider-selected", f alse);
832 }, 832 },
833 833
834 _updateRowsSize: function() 834 _updateRowsSize: function()
835 { 835 {
836 if (Runtime.experiments.isEnabled("canvasNetworkTimeline")) 836 if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
837 return; 837 return;
838 this._timelineGrid.element.classList.toggle("small", !this._networkLogLa rgeRowsSetting.get()); 838 this._timelineGrid.element.classList.toggle("small", !this._networkLogLa rgeRowsSetting.get());
839 } 839 }
840 } 840 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698