Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2445703002: Don't call FastNewFunctionContextStub if context is bigger than kMaxRegularHeapObjectSize. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't call FastNewFunctionContextStub if context is bigger than kMaxRegularHeapObjectSize. CL https://codereview.chromium.org/2177273002 changed FastNewFunctionContextStub to take a number of slots parameter and in-doing so removed the maximum slot count for FastNewFunctionContextStub. This made it possible to create a closure which is larger than kMaxRegularHeapObjectSize and so can't be allocated by FastNewFunctionContextStub. Reintroduce FastNewFunctionContextStub::kMaxSlots (but make the limit much larger) to ensure we call the runtime for contexts which need to be allocated in the LO space. BUG=chromium:655573 Committed: https://crrev.com/381b5437b2bf48885f870c7276e2f5cb4e9f8a02 Cr-Commit-Position: refs/heads/master@{#40541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -98 lines) Patch
M src/code-stubs.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +6 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-655573.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rmcilroy
Benedkit PTAL, thanks.
4 years, 1 month ago (2016-10-24 12:33:02 UTC) #7
Benedikt Meurer
LGTM, thanks.
4 years, 1 month ago (2016-10-24 17:02:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445703002/20001
4 years, 1 month ago (2016-10-24 17:18:43 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-10-24 17:22:49 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:11:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/381b5437b2bf48885f870c7276e2f5cb4e9f8a02
Cr-Commit-Position: refs/heads/master@{#40541}

Powered by Google App Engine
This is Rietveld 408576698