Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/crankshaft/ia32/lithium-codegen-ia32.cc

Issue 2445703002: Don't call FastNewFunctionContextStub if context is bigger than kMaxRegularHeapObjectSize. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h" 7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 bool need_write_barrier = true; 169 bool need_write_barrier = true;
170 // Argument to NewContext is the function, which is still in edi. 170 // Argument to NewContext is the function, which is still in edi.
171 int slots = info_->scope()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS; 171 int slots = info_->scope()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
172 Safepoint::DeoptMode deopt_mode = Safepoint::kNoLazyDeopt; 172 Safepoint::DeoptMode deopt_mode = Safepoint::kNoLazyDeopt;
173 if (info()->scope()->is_script_scope()) { 173 if (info()->scope()->is_script_scope()) {
174 __ push(edi); 174 __ push(edi);
175 __ Push(info()->scope()->scope_info()); 175 __ Push(info()->scope()->scope_info());
176 __ CallRuntime(Runtime::kNewScriptContext); 176 __ CallRuntime(Runtime::kNewScriptContext);
177 deopt_mode = Safepoint::kLazyDeopt; 177 deopt_mode = Safepoint::kLazyDeopt;
178 } else { 178 } else {
179 FastNewFunctionContextStub stub(isolate()); 179 if (slots <= FastNewFunctionContextStub::kMaximumSlots) {
180 __ mov(FastNewFunctionContextDescriptor::SlotsRegister(), 180 FastNewFunctionContextStub stub(isolate());
181 Immediate(slots)); 181 __ mov(FastNewFunctionContextDescriptor::SlotsRegister(),
182 __ CallStub(&stub); 182 Immediate(slots));
183 // Result of FastNewFunctionContextStub is always in new space. 183 __ CallStub(&stub);
184 need_write_barrier = false; 184 // Result of FastNewFunctionContextStub is always in new space.
185 need_write_barrier = false;
186 } else {
187 __ push(edi);
188 __ CallRuntime(Runtime::kNewFunctionContext);
189 }
185 } 190 }
186 RecordSafepoint(deopt_mode); 191 RecordSafepoint(deopt_mode);
187 192
188 // Context is returned in eax. It replaces the context passed to us. 193 // Context is returned in eax. It replaces the context passed to us.
189 // It's saved in the stack and kept live in esi. 194 // It's saved in the stack and kept live in esi.
190 __ mov(esi, eax); 195 __ mov(esi, eax);
191 __ mov(Operand(ebp, StandardFrameConstants::kContextOffset), eax); 196 __ mov(Operand(ebp, StandardFrameConstants::kContextOffset), eax);
192 197
193 // Copy parameters into context if necessary. 198 // Copy parameters into context if necessary.
194 int num_parameters = info()->scope()->num_parameters(); 199 int num_parameters = info()->scope()->num_parameters();
(...skipping 4967 matching lines...) Expand 10 before | Expand all | Expand 10 after
5162 __ bind(deferred->exit()); 5167 __ bind(deferred->exit());
5163 __ bind(&done); 5168 __ bind(&done);
5164 } 5169 }
5165 5170
5166 #undef __ 5171 #undef __
5167 5172
5168 } // namespace internal 5173 } // namespace internal
5169 } // namespace v8 5174 } // namespace v8
5170 5175
5171 #endif // V8_TARGET_ARCH_IA32 5176 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698