Inline constants for logging.

Inline constants for logging.

The constants are just for pretty printing and will never be
shared with other functions.
Inlining simplifies the code.

BUG=n/a
TEST=Ran trybots.

Committed: https://crrev.com/70d58ce3013b8f11dab8fb2b286acbc088ba971d
Cr-Commit-Position: refs/heads/master@{#427389}

[hidehiko, 2016-10-25 05:28:19]

Description was changed from

==========
Inline constants for logging.

The constants are just for pretty printing and will never be
shared with other funcsions.
So, inlining simplifies the code.

BUG=n/a
TEST=Ran trybots.
==========

to

==========
Inline constants for logging.

The constants are just for pretty printing and will never be
shared with other functions.
Inlining simplifies the code.

BUG=n/a
TEST=Ran trybots.
==========

[hidehiko, 2016-10-25 05:28:30]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 05:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 06:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 06:02:57]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2016-10-25 06:12:56]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-10-25 06:12:56]

Luis, this is the CL to address your comment in
https://codereview.chromium.org/2446563002/

PTAL.

[Luis Héctor Chávez, 2016-10-25 15:27:44]

lgtm

https://codereview.chromium.org/2445233003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.h (right):

https://codereview.chromium.org/2445233003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.h:266: // Outputs the stringified
|state| to |os|. This is only for logging purpose.
nit: s/purpose/purposes/

[hidehiko, 2016-10-25 16:50:35]

Thank you for quick review. Submitting.

https://codereview.chromium.org/2445233003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.h (right):

https://codereview.chromium.org/2445233003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.h:266: // Outputs the stringified
|state| to |os|. This is only for logging purpose.
On 2016/10/25 15:27:44, Luis Héctor Chávez wrote:
> nit: s/purpose/purposes/

Done.

[hidehiko, 2016-10-25 16:50:35]

Thank you for quick review. Submitting.

https://codereview.chromium.org/2445233003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.h (right):

https://codereview.chromium.org/2445233003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.h:266: // Outputs the stringified
|state| to |os|. This is only for logging purpose.
On 2016/10/25 15:27:44, Luis Héctor Chávez wrote:
> nit: s/purpose/purposes/

Done.

[hidehiko, 2016-10-25 16:50:39]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2016-10-25 16:50:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2445233003/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-10-25 16:50:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 17:22:54]

Description was changed from

==========
Inline constants for logging.

The constants are just for pretty printing and will never be
shared with other functions.
Inlining simplifies the code.

BUG=n/a
TEST=Ran trybots.
==========

to

==========
Inline constants for logging.

The constants are just for pretty printing and will never be
shared with other functions.
Inlining simplifies the code.

BUG=n/a
TEST=Ran trybots.
==========

[commit-bot: I haz the power, 2016-10-25 17:22:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-25 17:36:58]

Description was changed from

==========
Inline constants for logging.

The constants are just for pretty printing and will never be
shared with other functions.
Inlining simplifies the code.

BUG=n/a
TEST=Ran trybots.
==========

to

==========
Inline constants for logging.

The constants are just for pretty printing and will never be
shared with other functions.
Inlining simplifies the code.

BUG=n/a
TEST=Ran trybots.

Committed: https://crrev.com/70d58ce3013b8f11dab8fb2b286acbc088ba971d
Cr-Commit-Position: refs/heads/master@{#427389}
==========

[commit-bot: I haz the power, 2016-10-25 17:36:59]

Patchset 3 (id:??) landed as
https://crrev.com/70d58ce3013b8f11dab8fb2b286acbc088ba971d
Cr-Commit-Position: refs/heads/master@{#427389}