Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service.cc

Issue 2445233003: Inline constants for logging. (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/arc_auth_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_auth_service.cc
diff --git a/chrome/browser/chromeos/arc/arc_auth_service.cc b/chrome/browser/chromeos/arc/arc_auth_service.cc
index 3d8e8310780b068dca5742cd585b9a384631793a..cfed7e505fdf125f430c3e64374641718f4f093a 100644
--- a/chrome/browser/chromeos/arc/arc_auth_service.cc
+++ b/chrome/browser/chromeos/arc/arc_auth_service.cc
@@ -72,11 +72,6 @@ bool g_enable_check_android_management_for_testing = false;
// but present the UI to try again.
constexpr base::TimeDelta kArcSignInTimeout = base::TimeDelta::FromMinutes(5);
-const char kStateNotInitialized[] = "NOT_INITIALIZED";
-const char kStateStopped[] = "STOPPED";
-const char kStateFetchingCode[] = "FETCHING_CODE";
-const char kStateActive[] = "ACTIVE";
-
ash::ShelfDelegate* GetShelfDelegate() {
if (g_shelf_delegate_for_testing)
return g_shelf_delegate_for_testing;
@@ -958,13 +953,13 @@ void ArcAuthService::OnAndroidManagementPassed() {
std::ostream& operator<<(std::ostream& os, const ArcAuthService::State& state) {
switch (state) {
case ArcAuthService::State::NOT_INITIALIZED:
- return os << kStateNotInitialized;
+ return os << "NOT_INITIALIZED";
case ArcAuthService::State::STOPPED:
- return os << kStateStopped;
+ return os << "STOPPED";
case ArcAuthService::State::FETCHING_CODE:
- return os << kStateFetchingCode;
+ return os << "FETCHING_CODE";
case ArcAuthService::State::ACTIVE:
- return os << kStateActive;
+ return os << "ACTIVE";
default:
NOTREACHED();
return os;
« no previous file with comments | « chrome/browser/chromeos/arc/arc_auth_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698