Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: third_party/WebKit/Source/core/dom/DocumentUserGestureTokenTest.cpp

Issue 2445193005: Route setHasReceivedUserGesture() state for RemoteFrames (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DocumentUserGestureTokenTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/DocumentUserGestureTokenTest.cpp b/third_party/WebKit/Source/core/dom/DocumentUserGestureTokenTest.cpp
index 5df9cf43fa5cef849f70e8f43b26cdb7e04ca442..87734daafde731429309524ac00f2bb5b0bdf55a 100644
--- a/third_party/WebKit/Source/core/dom/DocumentUserGestureTokenTest.cpp
+++ b/third_party/WebKit/Source/core/dom/DocumentUserGestureTokenTest.cpp
@@ -9,28 +9,38 @@
namespace blink {
-TEST(DocumentUserGestureTokenTest, DocumentUserGestureState) {
- std::unique_ptr<DummyPageHolder> dummyPageHolder =
- DummyPageHolder::create(IntSize(800, 600));
- Document& document = dummyPageHolder->document();
- ASSERT_FALSE(document.hasReceivedUserGesture());
+class DocumentUserGestureTokenTest : public ::testing::Test {
+ public:
+ void SetUp() override {
+ m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600));
+ ASSERT_FALSE(document().hasReceivedUserGesture());
+ }
+ Document& document() const { return m_dummyPageHolder->document(); }
+
+ private:
+ std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
+};
+
+TEST_F(DocumentUserGestureTokenTest, NoGesture) {
// A nullptr Document* will not set user gesture state.
DocumentUserGestureToken::create(nullptr);
- EXPECT_FALSE(document.hasReceivedUserGesture());
+ EXPECT_FALSE(document().hasReceivedUserGesture());
+}
+TEST_F(DocumentUserGestureTokenTest, PossiblyExisting) {
// A non-null Document* will set state, but a subsequent nullptr Document*
// token will not override it.
- DocumentUserGestureToken::create(&document);
- EXPECT_TRUE(document.hasReceivedUserGesture());
+ DocumentUserGestureToken::create(&document());
+ EXPECT_TRUE(document().hasReceivedUserGesture());
DocumentUserGestureToken::create(nullptr);
- EXPECT_TRUE(document.hasReceivedUserGesture());
- document.clearHasReceivedUserGesture();
- ASSERT_FALSE(document.hasReceivedUserGesture());
+ EXPECT_TRUE(document().hasReceivedUserGesture());
+}
+TEST_F(DocumentUserGestureTokenTest, NewGesture) {
// UserGestureToken::Status doesn't impact Document gesture state.
- DocumentUserGestureToken::create(&document, UserGestureToken::NewGesture);
- EXPECT_TRUE(document.hasReceivedUserGesture());
+ DocumentUserGestureToken::create(&document(), UserGestureToken::NewGesture);
+ EXPECT_TRUE(document().hasReceivedUserGesture());
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698