Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2445193004: Suppress warnings on unplugging read-only removable devices. (Closed)

Created:
4 years, 1 month ago by yamaguchi
Modified:
4 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress warnings on unplugging read-only removable devices. BUG=653820 TEST=Manual test on a device by plugging & unplugging a write-protected SD card. Committed: https://crrev.com/4c59a1b8d24fb92f8acac25baed78cf6155f647c Cr-Commit-Position: refs/heads/master@{#427631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/device_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/device_event_router_unittest.cc View 5 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yamaguchi
ptal
4 years, 1 month ago (2016-10-26 06:58:14 UTC) #3
fukino
lgtm
4 years, 1 month ago (2016-10-26 07:27:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445193004/1
4 years, 1 month ago (2016-10-26 07:56:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 08:00:40 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 08:02:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c59a1b8d24fb92f8acac25baed78cf6155f647c
Cr-Commit-Position: refs/heads/master@{#427631}

Powered by Google App Engine
This is Rietveld 408576698