Suppress warnings on unplugging read-only removable devices.

chrome/browser/chromeos/extensions/file_manager/device_event_router_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/device_event_router.h"
 
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
@@ skipping 50 matching lines @@
 }  // namespace
 
 class DeviceEventRouterTest : public testing::Test {
  protected:
   void SetUp() override {
     device_event_router.reset(new DeviceEventRouterImpl());
   }
 
   // Creates a disk instance with |device_path| and |mount_path| for testing.
   Disk CreateTestDisk(const std::string& device_path,
-                      const std::string& mount_path) {
+                      const std::string& mount_path,
+                      bool is_read_only_hardware) {
     return Disk(device_path,
                 mount_path,
                 false,
                 "",
                 "",
                 "",
                 "",
                 "",
                 "",
                 "",
                 "",
                 "",
                 device_path,
                 chromeos::DEVICE_TYPE_UNKNOWN,
                 0,
                 false,
+                is_read_only_hardware,
                 false,
                 false,
                 false,
-                false,
                 false);
   }
 
   std::unique_ptr<DeviceEventRouterImpl> device_event_router;
 
  private:
   base::MessageLoop message_loop_;
 };
 
 TEST_F(DeviceEventRouterTest, AddAndRemoveDevice) {
-  const Disk disk1 = CreateTestDisk("/device/test", "/mount/path1");
-  const Disk disk1_unmounted = CreateTestDisk("/device/test", "");
+  const Disk disk1 = CreateTestDisk("/device/test", "/mount/path1", false);
+  const Disk disk1_unmounted = CreateTestDisk("/device/test", "", false);
   std::unique_ptr<Volume> volume(Volume::CreateForTesting(
       base::FilePath(FILE_PATH_LITERAL("/device/test")),
       base::FilePath(FILE_PATH_LITERAL("/mount/path1"))));
   device_event_router->OnDeviceAdded("/device/test");
   device_event_router->OnDiskAdded(disk1, true);
   device_event_router->OnVolumeMounted(chromeos::MOUNT_ERROR_NONE,
                                        *volume.get());
   device_event_router->OnVolumeUnmounted(chromeos::MOUNT_ERROR_NONE,
                                          *volume.get());
   device_event_router->OnDiskRemoved(disk1_unmounted);
   device_event_router->OnDeviceRemoved("/device/test");
   ASSERT_EQ(1u, device_event_router->events.size());
   EXPECT_EQ(file_manager_private::DEVICE_EVENT_TYPE_REMOVED,
             device_event_router->events[0].type);
   EXPECT_EQ("/device/test", device_event_router->events[0].device_path);
 }
 
 TEST_F(DeviceEventRouterTest, HardUnplugged) {
-  const Disk disk1 = CreateTestDisk("/device/test", "/mount/path1");
-  const Disk disk2 = CreateTestDisk("/device/test", "/mount/path2");
+  const Disk disk1 = CreateTestDisk("/device/test", "/mount/path1", false);
+  const Disk disk2 = CreateTestDisk("/device/test", "/mount/path2", false);
   device_event_router->OnDeviceAdded("/device/test");
   device_event_router->OnDiskAdded(disk1, true);
   device_event_router->OnDiskAdded(disk2, true);
   device_event_router->OnDiskRemoved(disk1);
   device_event_router->OnDiskRemoved(disk2);
   device_event_router->OnDeviceRemoved(kTestDevicePath);
   base::RunLoop().RunUntilIdle();
   ASSERT_EQ(2u, device_event_router->events.size());
   EXPECT_EQ(file_manager_private::DEVICE_EVENT_TYPE_HARD_UNPLUGGED,
             device_event_router->events[0].type);
   EXPECT_EQ("/device/test", device_event_router->events[0].device_path);
   EXPECT_EQ(file_manager_private::DEVICE_EVENT_TYPE_REMOVED,
             device_event_router->events[1].type);
   EXPECT_EQ("/device/test", device_event_router->events[1].device_path);
 }
 
+TEST_F(DeviceEventRouterTest, HardUnplugReadOnlyVolume) {
+  const Disk disk1 = CreateTestDisk("/device/test", "/mount/path1", true);
+  const Disk disk2 = CreateTestDisk("/device/test", "/mount/path2", true);
+  device_event_router->OnDeviceAdded("/device/test");
+  device_event_router->OnDiskAdded(disk1, true);
+  device_event_router->OnDiskAdded(disk2, true);
+  device_event_router->OnDiskRemoved(disk1);
+  device_event_router->OnDiskRemoved(disk2);
+  device_event_router->OnDeviceRemoved(kTestDevicePath);
+  base::RunLoop().RunUntilIdle();
+  ASSERT_EQ(1u, device_event_router->events.size());
+  EXPECT_EQ(file_manager_private::DEVICE_EVENT_TYPE_REMOVED,
+            device_event_router->events[0].type);
+  EXPECT_EQ("/device/test", device_event_router->events[0].device_path);
+  // Should not warn hard unplug because the volumes are read-only.
+}
+
 }  // namespace file_manager