Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: Source/core/html/track/vtt/VTTRegion.h

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Explicitly dispose of TextTrackList + fix handling of {Inband,Loadable}TextTrack Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/vtt/VTTRegion.h
diff --git a/Source/core/html/track/vtt/VTTRegion.h b/Source/core/html/track/vtt/VTTRegion.h
index c160162cddab63e6ca16bba3eb63628b3cee8439..8d1ca86a5bef71979345911cb7e2929bca0ff94f 100644
--- a/Source/core/html/track/vtt/VTTRegion.h
+++ b/Source/core/html/track/vtt/VTTRegion.h
@@ -35,6 +35,7 @@
#include "core/html/track/TextTrack.h"
#include "platform/Timer.h"
#include "platform/geometry/FloatPoint.h"
+#include "platform/heap/Handle.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/RefCounted.h"
@@ -45,11 +46,11 @@ class HTMLDivElement;
class VTTCueBox;
class VTTScanner;
-class VTTRegion : public RefCounted<VTTRegion> {
+class VTTRegion FINAL : public RefCountedWillBeGarbageCollectedFinalized<VTTRegion> {
public:
- static PassRefPtr<VTTRegion> create()
+ static PassRefPtrWillBeRawPtr<VTTRegion> create()
{
- return adoptRef(new VTTRegion());
+ return adoptRefWillBeNoop(new VTTRegion());
}
virtual ~VTTRegion();
@@ -94,6 +95,8 @@ public:
void displayLastVTTCueBox();
void willRemoveVTTCueBox(VTTCueBox*);
+ void trace(Visitor*);
+
private:
VTTRegion();
@@ -137,7 +140,7 @@ private:
// reference a destroyed TextTrack, as this member variable
// is cleared in the TextTrack destructor and it is generally
// set/reset within the addRegion and removeRegion methods.
- TextTrack* m_track;
+ RawPtrWillBeMember<TextTrack> m_track;
// Keep track of the current numeric value of the css "top" property.
double m_currentTop;

Powered by Google App Engine
This is Rietveld 408576698