Source/core/html/track/TrackBase.h - Issue 244493002: Oilpan: add transition types to track interface objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TrackBase.h

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Explicitly dispose of TextTrackList + fix handling of {Inband,Loadable}TextTrack Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/track/TextTrackList.cpp ('K') | « Source/core/html/track/TextTrackList.cpp ('k') | Source/core/html/track/TrackEvent.h » ('j') | Source/core/html/track/vtt/VTTRegionList.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/track/TrackBase.h

diff --git a/Source/core/html/track/TrackBase.h b/Source/core/html/track/TrackBase.h

index b291c68db363fd0a7b2e59c5c97e2c86a39aa651..d3625f076e5d349e4e089b20a86f5ba9e4c8b9c5 100644

--- a/Source/core/html/track/TrackBase.h

+++ b/Source/core/html/track/TrackBase.h

@@ -26,12 +26,13 @@

#ifndef TrackBase_h

#define TrackBase_h

+#include "platform/heap/Handle.h"

#include "wtf/RefCounted.h"

#include "wtf/text/AtomicString.h"

namespace WebCore {

-class TrackBase : public RefCounted<TrackBase> {

+class TrackBase : public RefCountedWillBeRefCountedGarbageCollected<TrackBase> {

public:

virtual ~TrackBase();

@@ -50,6 +51,8 @@ public:

AtomicString id() const { return m_id; }

void setId(const AtomicString& id) { m_id = id; }

+ virtual void trace(Visitor*) { }

protected:

TrackBase(Type, const AtomicString& label, const AtomicString& language, const AtomicString& id);