Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: Source/core/html/track/TextTrackCueList.h

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Explicitly dispose of TextTrackList + fix handling of {Inband,Loadable}TextTrack Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackCueList.h
diff --git a/Source/core/html/track/TextTrackCueList.h b/Source/core/html/track/TextTrackCueList.h
index b59552b516bf2453a6182dc8155dc0b88042108d..ace42e12f6bea179a6348cad1dcd763e664a8ba1 100644
--- a/Source/core/html/track/TextTrackCueList.h
+++ b/Source/core/html/track/TextTrackCueList.h
@@ -34,11 +34,11 @@
namespace WebCore {
-class TextTrackCueList : public RefCounted<TextTrackCueList>, public ScriptWrappable {
+class TextTrackCueList FINAL : public RefCountedWillBeGarbageCollectedFinalized<TextTrackCueList>, public ScriptWrappable {
public:
- static PassRefPtr<TextTrackCueList> create()
+ static PassRefPtrWillBeRawPtr<TextTrackCueList> create()
{
- return adoptRef(new TextTrackCueList);
+ return adoptRefWillBeNoop(new TextTrackCueList);
}
~TextTrackCueList() { }
@@ -50,20 +50,22 @@ public:
TextTrackCue* getCueById(const AtomicString&) const;
TextTrackCueList* activeCues();
- bool add(PassRefPtr<TextTrackCue>);
+ bool add(PassRefPtrWillBeRawPtr<TextTrackCue>);
bool remove(TextTrackCue*);
bool contains(TextTrackCue*) const;
bool updateCueIndex(TextTrackCue*);
+ void trace(Visitor*);
+
private:
TextTrackCueList();
- bool add(PassRefPtr<TextTrackCue>, size_t, size_t);
+ bool add(PassRefPtrWillBeRawPtr<TextTrackCue>, size_t, size_t);
void clear();
void invalidateCueIndexes(size_t);
- Vector<RefPtr<TextTrackCue> > m_list;
- RefPtr<TextTrackCueList> m_activeCues;
+ WillBeHeapVector<RefPtrWillBeMember<TextTrackCue> > m_list;
+ RefPtrWillBeMember<TextTrackCueList> m_activeCues;
};

Powered by Google App Engine
This is Rietveld 408576698