Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: Source/core/html/track/TextTrackCueList.cpp

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Explicitly dispose of TextTrackList + fix handling of {Inband,Loadable}TextTrack Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackCueList.cpp
diff --git a/Source/core/html/track/TextTrackCueList.cpp b/Source/core/html/track/TextTrackCueList.cpp
index 5e9b7c717850d4b835a7e93e15d5286663831a4b..a3dba2dc76bc38faed3e5e2edba3bdaba2038e5d 100644
--- a/Source/core/html/track/TextTrackCueList.cpp
+++ b/Source/core/html/track/TextTrackCueList.cpp
@@ -67,14 +67,14 @@ TextTrackCueList* TextTrackCueList::activeCues()
m_activeCues->clear();
for (size_t i = 0; i < m_list.size(); ++i) {
- RefPtr<TextTrackCue> cue = m_list[i];
+ RefPtrWillBeRawPtr<TextTrackCue> cue = m_list[i];
if (cue->isActive())
m_activeCues->add(cue);
}
return m_activeCues.get();
}
-bool TextTrackCueList::add(PassRefPtr<TextTrackCue> cue)
+bool TextTrackCueList::add(PassRefPtrWillBeRawPtr<TextTrackCue> cue)
{
ASSERT(cue->startTime() >= 0);
ASSERT(cue->endTime() >= 0);
@@ -82,14 +82,14 @@ bool TextTrackCueList::add(PassRefPtr<TextTrackCue> cue)
return add(cue, 0, m_list.size());
}
-bool TextTrackCueList::add(PassRefPtr<TextTrackCue> prpCue, size_t start, size_t end)
+bool TextTrackCueList::add(PassRefPtrWillBeRawPtr<TextTrackCue> prpCue, size_t start, size_t end)
{
ASSERT_WITH_SECURITY_IMPLICATION(start <= m_list.size());
ASSERT_WITH_SECURITY_IMPLICATION(end <= m_list.size());
// Maintain text track cue order:
// http://www.whatwg.org/specs/web-apps/current-work/#text-track-cue-order
- RefPtr<TextTrackCue> cue = prpCue;
+ RefPtrWillBeRawPtr<TextTrackCue> cue = prpCue;
if (start == end) {
if (!m_list.isEmpty() && (start > 0) && (m_list[start - 1].get() == cue.get()))
return false;
@@ -142,5 +142,11 @@ void TextTrackCueList::invalidateCueIndexes(size_t start)
m_list[i]->invalidateCueIndex();
}
+void TextTrackCueList::trace(Visitor* visitor)
+{
+ visitor->trace(m_list);
+ visitor->trace(m_activeCues);
+}
+
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698