Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java

Issue 24449007: [Android] Allow text handles to observe position of "parent" view (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java
index e6b17fbc15f1579012294af06a43a8bddfaee052..f55c070bb39930c55ab254c012cabd63c8d7c7c2 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java
@@ -396,16 +396,11 @@ public class SelectionHandleTest extends ContentShellTestBase {
touchCommon.longPressView(getContentView(), centerX, centerY);
assertWaitForHandlesShowingEquals(true);
+ assertWaitForHandleViewStopped(getStartHandle());
// No words wrap in the sample text so handles should be at the same y
// position.
assertEquals(getStartHandle().getPositionY(), getEndHandle().getPositionY());
-
- // In ContentShell, the handles are initially misplaced when they first appear. This is
- // fixed after the first time they are dragged (or the page is scrolled).
- // TODO(cjhopman): Fix this problem in ContentShell: http://crbug.com/243836
- dragHandleTo(getStartHandle(), centerX - 40, centerY - 40, 1);
- assertWaitForHandleViewStopped(getStartHandle());
}
private void clickToDismissHandles() throws Throwable {
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698