Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2013)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java

Issue 24449007: [Android] Allow text handles to observe position of "parent" view (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java
index 289dfa259c21e7938c7869811aa75221623421cd..d28286dfb035e488aac0436146a550a6275d69be 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java
@@ -8,6 +8,8 @@ import android.view.View;
import com.google.common.annotations.VisibleForTesting;
+import org.chromium.content.browser.PositionObserver;
+
/**
* CursorController for selecting a range of text.
*/
@@ -33,8 +35,11 @@ public abstract class SelectionHandleController implements CursorController {
private int mFixedHandleX;
private int mFixedHandleY;
- public SelectionHandleController(View parent) {
+ private PositionObserver mPositionObserver;
+
+ public SelectionHandleController(View parent, PositionObserver positionObserver) {
mParent = parent;
+ mPositionObserver = positionObserver;
}
/** Automatically show selection anchors when text is selected. */
@@ -190,11 +195,13 @@ public abstract class SelectionHandleController implements CursorController {
private void createHandlesIfNeeded(int startDir, int endDir) {
if (mStartHandle == null) {
mStartHandle = new HandleView(this,
- startDir == TEXT_DIRECTION_RTL ? HandleView.RIGHT : HandleView.LEFT, mParent);
+ startDir == TEXT_DIRECTION_RTL ? HandleView.RIGHT : HandleView.LEFT, mParent,
+ mPositionObserver);
}
if (mEndHandle == null) {
mEndHandle = new HandleView(this,
- endDir == TEXT_DIRECTION_RTL ? HandleView.LEFT : HandleView.RIGHT, mParent);
+ endDir == TEXT_DIRECTION_RTL ? HandleView.LEFT : HandleView.RIGHT, mParent,
+ mPositionObserver);
}
}

Powered by Google App Engine
This is Rietveld 408576698