Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2990)

Unified Diff: chrome/common/extensions/api/api.gyp

Issue 24449006: Add non_compiled_schema_files in api.gyp to disable schema model code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/json_schema_bundle_compile.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/api.gyp
diff --git a/chrome/common/extensions/api/api.gyp b/chrome/common/extensions/api/api.gyp
index 885f9dcfc275b9a61f4c1b349aa1502be776d41e..0fce15da5c69861e051ee31e3e17ce867a6363fe 100644
--- a/chrome/common/extensions/api/api.gyp
+++ b/chrome/common/extensions/api/api.gyp
@@ -20,6 +20,11 @@
'chromium_code': 1,
'conditions': [
['OS!="android"', {
+ # Disable schema compiler to generate model extension API code.
Yoyo Zhou 2013/10/17 00:41:14 kalman, can you suggest improvements to this? I do
Haojian Wu 2013/10/17 12:29:06 From what I understand, this will save the binary
not at google - send to devlin 2013/10/17 14:21:50 yes but there's way more than just infobars.
+ # Only register the extension functions in extension system.
+ 'non_compiled_schema_files': [
+ 'infobars.json',
Haojian Wu 2013/10/17 00:37:58 I search the whole chromium code and find infobars
+ ],
'schema_files': [
'activity_log_private.json',
'adview.json',
@@ -68,7 +73,6 @@
'idle.json',
'idltest.idl',
'image_writer_private.idl',
- 'infobars.json',
'input_ime.json',
'location.idl',
'management.json',
@@ -117,6 +121,8 @@
'windows.json',
],
}, { # OS=="android"
+ 'non_compiled_schema_files': [
Yoyo Zhou 2013/10/17 00:41:14 Rather than putting this here in every conditional
Haojian Wu 2013/10/17 12:29:06 Done.
+ ],
'schema_files': [
# These should be eliminated. See crbug.com/305852.
'activity_log_private.json',
@@ -142,6 +148,8 @@
],
}],
['chromeos==1', {
+ 'non_compiled_schema_files': [
+ ],
'schema_files': [
'diagnostics.idl',
'file_browser_handler_internal.json',
@@ -151,6 +159,8 @@
],
}],
['enable_webrtc==1', {
+ 'non_compiled_schema_files': [
+ ],
'schema_files': [
'webrtc_cast_send_transport.idl',
'webrtc_logging_private.idl',
« no previous file with comments | « build/json_schema_bundle_compile.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698