Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/common/extensions/api/api.gyp

Issue 24449006: Add non_compiled_schema_files in api.gyp to disable schema model code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/json_schema_bundle_compile.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'api', 8 'target_name': 'api',
9 'type': 'static_library', 9 'type': 'static_library',
10 'sources': [ 10 'sources': [
11 '<@(schema_files)', 11 '<@(schema_files)',
12 ], 12 ],
13 # TODO(jschuh): http://crbug.com/167187 size_t -> int 13 # TODO(jschuh): http://crbug.com/167187 size_t -> int
14 'msvs_disabled_warnings': [ 4267 ], 14 'msvs_disabled_warnings': [ 4267 ],
15 'includes': [ 15 'includes': [
16 '../../../../build/json_schema_bundle_compile.gypi', 16 '../../../../build/json_schema_bundle_compile.gypi',
17 '../../../../build/json_schema_compile.gypi', 17 '../../../../build/json_schema_compile.gypi',
18 ], 18 ],
19 'variables': { 19 'variables': {
20 'chromium_code': 1, 20 'chromium_code': 1,
21 'conditions': [ 21 'conditions': [
22 ['OS!="android"', { 22 ['OS!="android"', {
23 # Disable schema compiler to generate model extension API code.
Yoyo Zhou 2013/10/17 00:41:14 kalman, can you suggest improvements to this? I do
Haojian Wu 2013/10/17 12:29:06 From what I understand, this will save the binary
not at google - send to devlin 2013/10/17 14:21:50 yes but there's way more than just infobars.
24 # Only register the extension functions in extension system.
25 'non_compiled_schema_files': [
26 'infobars.json',
Haojian Wu 2013/10/17 00:37:58 I search the whole chromium code and find infobars
27 ],
23 'schema_files': [ 28 'schema_files': [
24 'activity_log_private.json', 29 'activity_log_private.json',
25 'adview.json', 30 'adview.json',
26 'alarms.idl', 31 'alarms.idl',
27 'app_current_window_internal.idl', 32 'app_current_window_internal.idl',
28 'app_runtime.idl', 33 'app_runtime.idl',
29 'app_window.idl', 34 'app_window.idl',
30 'audio.idl', 35 'audio.idl',
31 'autotest_private.idl', 36 'autotest_private.idl',
32 'bluetooth.idl', 37 'bluetooth.idl',
(...skipping 28 matching lines...) Expand all
61 'file_system.idl', 66 'file_system.idl',
62 'font_settings.json', 67 'font_settings.json',
63 'hangouts_private.idl', 68 'hangouts_private.idl',
64 'history.json', 69 'history.json',
65 'i18n.json', 70 'i18n.json',
66 'identity.idl', 71 'identity.idl',
67 'identity_private.idl', 72 'identity_private.idl',
68 'idle.json', 73 'idle.json',
69 'idltest.idl', 74 'idltest.idl',
70 'image_writer_private.idl', 75 'image_writer_private.idl',
71 'infobars.json',
72 'input_ime.json', 76 'input_ime.json',
73 'location.idl', 77 'location.idl',
74 'management.json', 78 'management.json',
75 'manifest_types.json', 79 'manifest_types.json',
76 'mdns.idl', 80 'mdns.idl',
77 'media_galleries.idl', 81 'media_galleries.idl',
78 'media_galleries_private.idl', 82 'media_galleries_private.idl',
79 'media_player_private.json', 83 'media_player_private.json',
80 'metrics_private.json', 84 'metrics_private.json',
81 'music_manager_private.idl', 85 'music_manager_private.idl',
(...skipping 28 matching lines...) Expand all
110 'top_sites.json', 114 'top_sites.json',
111 'usb.idl', 115 'usb.idl',
112 'virtual_keyboard_private.json', 116 'virtual_keyboard_private.json',
113 'web_navigation.json', 117 'web_navigation.json',
114 'web_request.json', 118 'web_request.json',
115 'webstore_private.json', 119 'webstore_private.json',
116 'webview.json', 120 'webview.json',
117 'windows.json', 121 'windows.json',
118 ], 122 ],
119 }, { # OS=="android" 123 }, { # OS=="android"
124 'non_compiled_schema_files': [
Yoyo Zhou 2013/10/17 00:41:14 Rather than putting this here in every conditional
Haojian Wu 2013/10/17 12:29:06 Done.
125 ],
120 'schema_files': [ 126 'schema_files': [
121 # These should be eliminated. See crbug.com/305852. 127 # These should be eliminated. See crbug.com/305852.
122 'activity_log_private.json', 128 'activity_log_private.json',
123 'alarms.idl', 129 'alarms.idl',
124 'app_runtime.idl', 130 'app_runtime.idl',
125 'app_window.idl', 131 'app_window.idl',
126 'context_menus.json', 132 'context_menus.json',
127 'downloads.idl', 133 'downloads.idl',
128 'events.json', 134 'events.json',
129 'feedback_private.idl', 135 'feedback_private.idl',
130 'file_system.idl', 136 'file_system.idl',
131 'manifest_types.json', 137 'manifest_types.json',
132 'omnibox.json', 138 'omnibox.json',
133 'permissions.json', 139 'permissions.json',
134 'runtime.json', 140 'runtime.json',
135 'storage.json', 141 'storage.json',
136 'sync_file_system.idl', 142 'sync_file_system.idl',
137 'tab_capture.idl', 143 'tab_capture.idl',
138 'tabs.json', 144 'tabs.json',
139 'web_navigation.json', 145 'web_navigation.json',
140 'web_request.json', 146 'web_request.json',
141 'windows.json', 147 'windows.json',
142 ], 148 ],
143 }], 149 }],
144 ['chromeos==1', { 150 ['chromeos==1', {
151 'non_compiled_schema_files': [
152 ],
145 'schema_files': [ 153 'schema_files': [
146 'diagnostics.idl', 154 'diagnostics.idl',
147 'file_browser_handler_internal.json', 155 'file_browser_handler_internal.json',
148 'log_private.idl', 156 'log_private.idl',
149 'wallpaper.json', 157 'wallpaper.json',
150 'wallpaper_private.json', 158 'wallpaper_private.json',
151 ], 159 ],
152 }], 160 }],
153 ['enable_webrtc==1', { 161 ['enable_webrtc==1', {
162 'non_compiled_schema_files': [
163 ],
154 'schema_files': [ 164 'schema_files': [
155 'webrtc_cast_send_transport.idl', 165 'webrtc_cast_send_transport.idl',
156 'webrtc_logging_private.idl', 166 'webrtc_logging_private.idl',
157 'webrtc_udp_transport.idl', 167 'webrtc_udp_transport.idl',
158 ], 168 ],
159 }], 169 }],
160 ], 170 ],
161 'cc_dir': 'chrome/common/extensions/api', 171 'cc_dir': 'chrome/common/extensions/api',
162 'root_namespace': 'extensions::api', 172 'root_namespace': 'extensions::api',
163 }, 173 },
164 'dependencies': [ 174 'dependencies': [
165 '<(DEPTH)/skia/skia.gyp:skia', 175 '<(DEPTH)/skia/skia.gyp:skia',
166 '<(DEPTH)/sync/sync.gyp:sync', 176 '<(DEPTH)/sync/sync.gyp:sync',
167 ], 177 ],
168 'conditions': [ 178 'conditions': [
169 ['chromeos==1', { 179 ['chromeos==1', {
170 'dependencies': [ 180 'dependencies': [
171 '<(DEPTH)/chrome/chrome.gyp:drive_proto', 181 '<(DEPTH)/chrome/chrome.gyp:drive_proto',
172 ], 182 ],
173 }], 183 }],
174 ], 184 ],
175 }, 185 },
176 ], 186 ],
177 } 187 }
OLDNEW
« no previous file with comments | « build/json_schema_bundle_compile.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698