third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp - Issue 2444813002: Remove unsafe mode to enable es3 api by default for WebGL2 and ES3 context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp

Issue 2444813002: Remove unsafe mode to enable es3 api by default for WebGL2 and ES3 context (Closed)

Patch Set: remove runtime flag unsafeES3APIs from blink webgl module Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp

index 65d594fcf56829838f1ef664a98ca31012ee86d8..d42ff15e966cd5551aa43af7159cffc7e24f005a 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp

@@ -38,12 +38,12 @@ CanvasRenderingContext* WebGL2RenderingContext::Factory::create(

HTMLCanvasElement* canvas,

const CanvasContextCreationAttributes& attrs,

Document&) {

- if (!RuntimeEnabledFeatures::unsafeES3APIsEnabled()) {

+ /* if (!RuntimeEnabledFeatures::unsafeES3APIsEnabled()) {

canvas->dispatchEvent(WebGLContextEvent::create(

EventTypeNames::webglcontextcreationerror, false, true,

"Creation of WebGL2 contexts disabled."));

return nullptr;

- }

+ } */

std::unique_ptr<WebGraphicsContext3DProvider> contextProvider(

createWebGraphicsContext3DProvider(canvas, attrs, 2));