Remove unsafe mode to enable es3 api by default for WebGL2 and ES3 context

third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/webgl/WebGL2RenderingContext.h"
 
 #include "bindings/modules/v8/OffscreenCanvasRenderingContext2DOrWebGLRenderingContextOrWebGL2RenderingContext.h"
 #include "bindings/modules/v8/RenderingContext.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
@@ skipping 20 matching lines @@
 #include "public/platform/Platform.h"
 #include "public/platform/WebGraphicsContext3DProvider.h"
 #include <memory>
 
 namespace blink {
 
 CanvasRenderingContext* WebGL2RenderingContext::Factory::create(
     HTMLCanvasElement* canvas,
     const CanvasContextCreationAttributes& attrs,
     Document&) {
-  if (!RuntimeEnabledFeatures::unsafeES3APIsEnabled()) {
+  /* if (!RuntimeEnabledFeatures::unsafeES3APIsEnabled()) {
     canvas->dispatchEvent(WebGLContextEvent::create(
         EventTypeNames::webglcontextcreationerror, false, true,
         "Creation of WebGL2 contexts disabled."));
     return nullptr;
-  }
+  } */
 
   std::unique_ptr<WebGraphicsContext3DProvider> contextProvider(
       createWebGraphicsContext3DProvider(canvas, attrs, 2));
   if (!contextProvider)

[Zhenyao Mo, 2016/10/25 16:52:05]

I am wondering if only with the blink side change (so UnsafeES3APIs still
effective in command buffer but not in blink), will this just return null if
--enable-unsafe-es3-apis isn't passed in?

If yes, then we can land the blink side change first.

Yunchao, can you verify the above question and if yes, can you split the blink
side work to a separate CL and then we can land it?

[yunchao, 2016/10/26 03:27:09]

I tried your suggestion in my local Linux desktop, the answer is "yes".
contextProvider would be null. It fails to be created because GLES2DecoderImpl
would fail during initiation when --enable-unsafe-es3-apis is not passed in.

Please see the change at https://codereview.chromium.org/2451943002/

     return nullptr;
   gpu::gles2::GLES2Interface* gl = contextProvider->contextGL();
   std::unique_ptr<Extensions3DUtil> extensionsUtil =
       Extensions3DUtil::create(gl);
   if (!extensionsUtil)
     return nullptr;
   if (extensionsUtil->supportsExtension("GL_EXT_debug_marker")) {
     String contextLabel(
         String::format("WebGL2RenderingContext-%p", contextProvider.get()));
     gl->PushGroupMarkerEXT(0, contextLabel.ascii().data());
@@ skipping 100 matching lines @@
   visitor->traceWrappers(m_webglCompressedTexturePVRTC);
   visitor->traceWrappers(m_webglCompressedTextureS3TC);
   visitor->traceWrappers(m_webglCompressedTextureS3TCsRGB);
   visitor->traceWrappers(m_webglDebugRendererInfo);
   visitor->traceWrappers(m_webglDebugShaders);
   visitor->traceWrappers(m_webglLoseContext);
   WebGL2RenderingContextBase::traceWrappers(visitor);
 }
 
 }  // namespace blink